[Feat] 챗봇 페이지 제작#72
Merged
Hidden character warning
The head ref may contain hidden characters: "70-feat/\ucc57\ubd07-\ud398\uc774\uc9c0-\uc81c\uc791"
Merged
Conversation
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
KyeongJooni
reviewed
Jan 30, 2026
|
|
||
| `; | ||
|
|
||
| export default function ChatbotPage() { |
Member
There was a problem hiding this comment.
아까 말씀드렸지만 화살표 함수 사용을 권장합니다!
Comment on lines
+13
to
+14
| 'rounded-[var(--radius-l)]', | ||
| 'max-w-[720px]', |
Member
There was a problem hiding this comment.
가로 맥스값 변경이 다른 페이지에서 사용할 때 이상하게 나올 수도 있을 것 같아서
chatbotNotice variant에만 720px를 적용하고 기본으로는 기존에 속성 남기면 좋을 것 같습니다!!
Collaborator
Author
There was a problem hiding this comment.
이 방법 안 쓰고 계속 기존 속성 변경했는데 감사합니다!
Comment on lines
+3
to
+12
| export type ChatMessage = { | ||
| id: string; | ||
| role: 'bot' | 'user'; | ||
| content: string; | ||
| status?: 'loading' | 'done'; | ||
| }; | ||
|
|
||
| type ChatMessageListProps = { | ||
| messages: ChatMessage[]; | ||
| }; |
Member
There was a problem hiding this comment.
지금 정의 되는 타입이 두개 정도 인데 model에 types.ts로 분리하는 방법도 있어보입니다!! 고려를 하시면 좋을 것 같아요 꼭 이렇게 수정하라는 건 아닙니다!
PR 검증 결과✅ TypeScript: 통과 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 주요 변경사항
📝 작업 상세 내용
✅ 체크리스트
Close #번호추가📸 스크린샷 (선택)
2026-01-29.1.45.39.mov
🔍 기타 참고사항
긴 문장 아예 줄 바꿈 안 되게 바꿔놨습니다.!
🔗 관련 이슈