Merged
Conversation
- 현재는 사용하지 않는 기능이므로, `@Service` 미사용
Closed
There was a problem hiding this comment.
Pull request overview
This PR implements file upload functionality using OCI Object Storage through pre-authenticated URLs. The implementation allows clients to request temporary upload URLs with a 15-minute expiration time, enabling direct file uploads to OCI without exposing permanent credentials.
- Added OCI Object Storage client configuration with authentication setup
- Implemented pre-authenticated URL generation with unique file naming
- Created utility function for retrieving object URLs from bucket
- Secured the new endpoint with user role authorization
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Added OCI SDK dependencies for Object Storage integration |
| .gitignore | Excluded private key files (.pem) from version control |
| src/main/resources/application.yml | Added OCI configuration properties for tenant, user, region, and bucket settings |
| src/main/kotlin/land/leets/global/config/OciConfig.kt | Configured OCI ObjectStorage client bean with authentication provider |
| src/main/kotlin/land/leets/global/config/SecurityConfig.kt | Added authorization rule for the pre-authenticated URL endpoint |
| src/main/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrl.kt | Defined interface for pre-authenticated URL generation use case |
| src/main/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImpl.kt | Implemented pre-authenticated URL generation with UUID-based unique file naming |
| src/main/kotlin/land/leets/domain/storage/usecase/GetObjectUrl.kt | Defined interface for object URL retrieval utility |
| src/main/kotlin/land/leets/domain/storage/usecase/GetObjectUrlImpl.kt | Implemented object URL construction from file name |
| src/main/kotlin/land/leets/domain/storage/presentation/dto/PreAuthenticatedUrlResponse.kt | Created response DTO for pre-authenticated URL |
| src/main/kotlin/land/leets/domain/storage/presentation/StorageController.kt | Exposed POST endpoint for pre-authenticated URL generation |
| src/test/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImplTest.kt | Added unit tests for pre-authenticated URL generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImplTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/land/leets/domain/storage/presentation/StorageController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/land/leets/domain/storage/presentation/StorageController.kt
Show resolved
Hide resolved
src/main/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImpl.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImplTest.kt
Outdated
Show resolved
Hide resolved
jwnnoh
reviewed
Dec 30, 2025
src/main/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImpl.kt
Outdated
Show resolved
Hide resolved
rootTiket
reviewed
Dec 30, 2025
Member
rootTiket
left a comment
rootTiket
left a comment
There was a problem hiding this comment.
고생하셨습니다~ 코멘트 한번 읽어주시면 감사할 것 같아요 :)
src/test/kotlin/land/leets/domain/storage/usecase/GetPreAuthenticatedUrlImplTest.kt
Outdated
Show resolved
Hide resolved
jwnnoh
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
OCI Object Storage를 이용한 파일 업로드 기능을 구현합니다.
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항
comment에 추가하도록 하겠습니다.