Conversation
…into feat/#52/이미지-관련-api-연결
Closed
2 tasks
soyun-git121
reviewed
Aug 4, 2025
Collaborator
soyun-git121
left a comment
There was a problem hiding this comment.
적어주신거 프로필 수정시 이미지 불러올때 사용해보겠습니다!
ImagePreviewItem 컴포넌트를 마이페이지에서도 재사용 하면 되는건가용?
sispo3314
approved these changes
Aug 4, 2025
Collaborator
sispo3314
left a comment
There was a problem hiding this comment.
수고하셨습니다!! 구현도 잘 되어있고 코드 분리도 깔끔해서 충돌만 해결하시고 머지하시면 될 것 같습니다! bbbb
soyun-git121
approved these changes
Aug 4, 2025
Member
Author
네넵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련된 이슈
📝 작업 내용
getPresignedUrls()과uploadToS3()로직을 합친 훅useS3UploadFlow()추가<이미지 업로드 플로우 설명>
getPresignedUrls()),uploadToS3()),📸 스크린샷
2025-08-05.1.35.18.mov
🚨 이슈
📣 리뷰 요구사항
리뷰 작성 API 처럼 api 요청 시 이미지 url을 보내줘야 하는 경우가 있다면
useS3UploadFlow함수를 사용해서 이미지를 S3에 업로드한 후해당 이미지 url을 보내줘야 합니다!
단일 파일은 테스트해봤는데 여러 개 파일은 아직 잘 되는지 모르겠어서 한 번 해보시고 안되면 ,, 맞게 수정하셔도 됩니다..!
코드 주석처리 된 부분은 제가 use어쩌구Mutation 으로 분리한 함수를 사용해서 쓰려다가 너무 복잡해져서 ,, 그냥 해당 함수를 안쓰도록 수정했는데 나중에 리팩토링해보려고 놔뒀습니다!!
✅ 체크리스트