check for __cpuidex in intrin.h #757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what is actually used, rather than __cpuid. Due to what I assume is a bug in mingw-w64, __cpuid is prototyped on ARM64, even though there is no definition, which caused this check to succeed and compilation to later fail due to missing __cpuidex (it would have failed at link time if __cpuid was used instead)
Author
|
I have separately reported the most likely erroneous presence of |
Author
|
I think mingw-w64/mingw-w64@69846cf would fix the build error on arm64, but I also think it would be more correct to check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what is actually used, rather than __cpuid. Due to what I assume is a bug in mingw-w64, __cpuid is prototyped on ARM64, even though there is no definition, which caused this check to succeed and compilation to later fail due to missing __cpuidex (it would have failed at link time if __cpuid was used instead)