Skip to content

ci(MSP-5160): check out repo so commitlint rules are enforced - #706

Merged
Marcin Michalski (marmichalski) merged 1 commit into
masterfrom
ticket/MSP-5160-commit-lint
Aug 14, 2026
Merged

ci(MSP-5160): check out repo so commitlint rules are enforced#706
Marcin Michalski (marmichalski) merged 1 commit into
masterfrom
ticket/MSP-5160-commit-lint

Conversation

@maks-rafalko

@maks-rafalko Maks Rafalko (maks-rafalko) commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Why

.github/workflows/conventional-commits.yaml points commitlintRulesPath at this repo's custom commitlint rules (.github/commitlint.config.js) but never checks the repo out, so the file is never present in the workspace. Every PR title passes unchecked as a result, despite scope-empty: [2, 'never'] in the config.

What

  • Add contents: read alongside the existing pull-requests: read permission
  • Add an actions/checkout@v7 step (SHA already pinned in .github/workflows/ci.yml) with show-progress: false, as the first step of the job, before the conventional-pull-request-action step

Result

Now the commitlint rules file is present in the workspace and PR titles are actually validated against it.

The Validate PR title job pointed at .github/commitlint.config.js via
commitlintRulesPath but never checked the repo out, so the action
found no rules file and every PR title passed unchecked.

Mirrors Lendable/doctrine-migrations-extensions#173.
@maks-rafalko Maks Rafalko (maks-rafalko) added the ai-implemented PR authored by an AI agent label Aug 14, 2026
@maks-rafalko
Maks Rafalko (maks-rafalko) marked this pull request as ready for review August 14, 2026 13:21
Merged via the queue into master with commit 4b3f734 Aug 14, 2026
10 checks passed
@marmichalski
Marcin Michalski (marmichalski) deleted the ticket/MSP-5160-commit-lint branch August 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-implemented PR authored by an AI agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants