ci(MSP-5160): check out repo so commitlint rules are enforced - #706
Merged
Marcin Michalski (marmichalski) merged 1 commit intoAug 14, 2026
Merged
Conversation
The Validate PR title job pointed at .github/commitlint.config.js via commitlintRulesPath but never checked the repo out, so the action found no rules file and every PR title passed unchecked. Mirrors Lendable/doctrine-migrations-extensions#173.
Maks Rafalko (maks-rafalko)
marked this pull request as ready for review
August 14, 2026 13:21
Marcin Michalski (marmichalski)
approved these changes
Aug 14, 2026
Marcin Michalski (marmichalski)
deleted the
ticket/MSP-5160-commit-lint
branch
August 14, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.github/workflows/conventional-commits.yamlpointscommitlintRulesPathat this repo's custom commitlint rules (.github/commitlint.config.js) but never checks the repo out, so the file is never present in the workspace. Every PR title passes unchecked as a result, despitescope-empty: [2, 'never']in the config.What
contents: readalongside the existingpull-requests: readpermissionactions/checkout@v7step (SHA already pinned in.github/workflows/ci.yml) withshow-progress: false, as the first step of the job, before theconventional-pull-request-actionstepResult
Now the commitlint rules file is present in the workspace and PR titles are actually validated against it.