mirror: use FS.createPath (mkdirp) and verify parents; surface ENOENT cleanly#123
Conversation
✅ Deploy Preview for wyrrdmaek ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Wyrd-Engine/web/workers/pyRunner.js
Lines 491 to 496 in 8ca251c
The new ensureParentDirectory gate checks analysis?.object?.isFolder === true to verify that the parent node is a directory. FS.analyzePath returns an FS node whose type is indicated by mode; it does not populate an isFolder boolean. As written, isFolder will always be false even when the path exists as a directory, so every call throws ParentDirMissing and mirror writes will fail immediately. Use instance.FS.isDir(analysis.object.mode) (or similar) to detect directories instead.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Testing
Codex Task