Skip to content

Ensure Visuals tab tracks a single run #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LennartvdM merged 1 commit into from
Nov 14, 2025
Merged

Ensure Visuals tab tracks a single run #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const calendarHistoryState = {
panel: null,
list: null,
activeId: null,
currentEntry: null,
currentRun: null,
summaryContainer: null,
summaryList: null,
summaryMeta: null,
Expand Down Expand Up @@ -245,6 +245,7 @@ function resolveLegacyPng(payload) {
function updateVisuals(payload) {
lastVisualPayload = payload && typeof payload === 'object' ? payload : null;
if (visualsState.useLegacy) {
resetVisualsInstance();
const src = resolveLegacyPng(lastVisualPayload);
if (visualsState.fallbackImg) {
if (src) {
Expand Down Expand Up @@ -275,6 +276,24 @@ function updateVisuals(payload) {
} catch (error) {
console.error('[visuals] failed to update radial urchin:', error);
}
} else if (!visualsState.useLegacy && visualsState.mount && visualsState.mount.childElementCount > 0) {
visualsState.mount.replaceChildren();
}
}

function resetVisualsInstance() {
if (visualsState.urchin) {
try {
if (typeof visualsState.urchin.destroy === 'function') {
visualsState.urchin.destroy();
}
} catch (error) {
console.warn('[visuals] failed to destroy existing radial urchin:', error);
}
visualsState.urchin = null;
}
if (visualsState.mount && visualsState.mount.childNodes.length > 0) {
visualsState.mount.replaceChildren();
}
}

Expand All @@ -291,6 +310,7 @@ function maybeCreateUrchinInstance(payload) {
if (visualsState.useLegacy || visualsState.urchin || !visualsState.mount || !hasVisualEvents(payload)) {
return;
}
resetVisualsInstance();
const instance = createRadialUrchin(visualsState.mount, {
data: payload,
mode: 'day-rings',
Expand Down Expand Up @@ -654,11 +674,11 @@ function renderCalendarHistorySummary() {
return;
}

const { activeId, runHistory, currentEntry } = calendarHistoryState;
const { activeId, runHistory, currentRun } = calendarHistoryState;
const activeIndex = activeId ? runHistory.findIndex((entry) => entry.id === activeId) : -1;
const entry =
currentEntry && currentEntry.id === activeId
? currentEntry
currentRun && currentRun.id === activeId
? currentRun
: activeIndex !== -1
? runHistory[activeIndex]
: null;
Expand Down Expand Up @@ -740,14 +760,14 @@ function setCurrentCalendarHistoryEntry(entry, options = {}) {

if (!entry || !payload || typeof payload !== 'object') {
calendarHistoryState.activeId = null;
calendarHistoryState.currentEntry = null;
calendarHistoryState.currentRun = null;
updateVisuals(null);
if (showEmptyState) {
showVisualsEmptyState();
}
} else {
calendarHistoryState.activeId = entry.id;
calendarHistoryState.currentEntry = {
calendarHistoryState.currentRun = {
...entry,
summary: entry.summary && typeof entry.summary === 'object' ? { ...entry.summary } : null,
rawResult: cloneCalendarHistoryPayload(payload) || payload,
Expand Down Expand Up @@ -1237,7 +1257,7 @@ function setJsonPayload(payload, options = {}) {
updateVisuals(parsedPayload);
if (hasVisualEvents(parsedPayload)) {
hideVisualsOverlay();
} else if (!calendarHistoryState.currentEntry && calendarHistoryState.runHistory.length === 0) {
} else if (!calendarHistoryState.currentRun && calendarHistoryState.runHistory.length === 0) {
showVisualsEmptyState();
}
}
Expand Down Expand Up @@ -2405,7 +2425,7 @@ async function handleGenerate(event) {
updateVisuals(null);
showVisualsOverlay('Generating schedule…', { loading: true });
calendarHistoryState.activeId = null;
calendarHistoryState.currentEntry = null;
calendarHistoryState.currentRun = null;
renderCalendarRunHistory();

beginConsoleRun('Generating payload…', { autoSwitch: false });
Expand Down