Restore human-readable purity summary logs#179
Conversation
✅ Deploy Preview for wyrrdmaek ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (checkerErrorRuns > 0) { | ||
| detailParts.push(`${checkerErrorRuns}/${totalRuns} runs had checker errors.`); | ||
| } | ||
| if (detailParts.length === 0) { | ||
| detailParts.push(`All ${totalRuns} runs match raw and share totals.`); |
There was a problem hiding this comment.
Mention checker crashes when run details are missing
If the purity checker crashes before generating per‑run results (e.g. the fallback path in computeBatchPuritySummary sets totalRuns but no runs and didCheckerError = true), this logic only looks at checkerErrorRuns derived from summary.runs. With an empty array the count is zero, so the summary logs All ${totalRuns} runs match raw and share totals. even though statusLabel is ERROR, which misleads operators and hides the crash. The detail text should also consider summary.didCheckerError so that an error is reported instead of claiming all runs matched.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task