Skip to content

Restore human-readable purity summary logs#179

Merged
LennartvdM merged 1 commit into
mainfrom
codex/restore-human-readable-purity-summary-logs
Nov 17, 2025
Merged

Restore human-readable purity summary logs#179
LennartvdM merged 1 commit into
mainfrom
codex/restore-human-readable-purity-summary-logs

Conversation

@LennartvdM
Copy link
Copy Markdown
Owner

Summary

  • restore the natural language purity summary header and observation lines
  • remove the telemetry-style summary builder in favour of readable sentences that highlight status, averages, activities, and worst runs
  • keep the detailed per-run logging unchanged while ensuring summary errors are still reported

Testing

  • Not run (not requested)

Codex Task

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 17, 2025

Deploy Preview for wyrrdmaek ready!

Name Link
🔨 Latest commit e01d531
🔍 Latest deploy log https://app.netlify.com/projects/wyrrdmaek/deploys/691b4ab2b46ec6000823896e
😎 Deploy Preview https://deploy-preview-179--wyrrdmaek.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LennartvdM LennartvdM merged commit a18a3b0 into main Nov 17, 2025
5 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/app.js
Comment on lines +3757 to +3761
if (checkerErrorRuns > 0) {
detailParts.push(`${checkerErrorRuns}/${totalRuns} runs had checker errors.`);
}
if (detailParts.length === 0) {
detailParts.push(`All ${totalRuns} runs match raw and share totals.`);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Mention checker crashes when run details are missing

If the purity checker crashes before generating per‑run results (e.g. the fallback path in computeBatchPuritySummary sets totalRuns but no runs and didCheckerError = true), this logic only looks at checkerErrorRuns derived from summary.runs. With an empty array the count is zero, so the summary logs All ${totalRuns} runs match raw and share totals. even though statusLabel is ERROR, which misleads operators and hides the crash. The detail text should also consider summary.didCheckerError so that an error is reported instead of claiming all runs matched.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant