Add zero drift handling for purity narrative#184
Conversation
✅ Deploy Preview for wyrrdmaek ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (isZeroDriftBatch) { | ||
| paragraphs.push( | ||
| `This batch of ${totalRuns} runs is passing the purity check, with ${pureRuns} marked pure and 0 flagged impure. On average, the Share view is in near-perfect agreement with the raw schedules; totals match to within rounding error.` | ||
| ); |
There was a problem hiding this comment.
The new zero‑drift branch hardcodes the sentence with ${pureRuns} marked pure and 0 flagged impure and declares the batch “passing”, ignoring the actual impureRuns value that is still calculated above. If the backend ever reports a batch with small drift (within the 1‑minute epsilon) but still has impure runs for other reasons or because counts are missing, the UI will incorrectly state that there are zero impure runs and that the batch passes. This misreports the state of the batch; the message should derive both the status word and the impure count from the data rather than assuming zero.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task