Skip to content

Memory safety enhancements #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Memory safety enhancements #20

wants to merge 9 commits into from

Conversation

@jasondilworth56
Copy link

Addresses a number of issues raised in #8.

Not my code, but having been in conversation with @parasyte I have forked his branches to turn into this PR. There is another to follow for error handling improvements.

@parasyte
Fix soundness issues and resource leaks
52c5058 
- The close methods were incorrect, replaced with impl Drop
- Dropping Connection would invalidate Blocking, so tied the lifetimes
  together to prevent further soundness issues (see required changes
  for doctests).
@parasyte
Reduce unsafe keyword uses
608a1a0 
- This extends the surface area of unsafe slightly.
@parasyte
These cannot safely be exposed publicly because they accept raw pointers
243feb3
@parasyte
This does not need mutable access
d562179
@parasyte
Transmute is unnecessary
f91de43
@parasyte
Fix a resource leak while handling errors
9964e7e
@parasyte
Lazily read Header
c5150ae 
- Fixes #3
@parasyte
Fix error handling
d755c45 
- Closes #4
@LeoAdamek LeoAdamek self-requested a review February 13, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeoAdamek LeoAdamek Awaiting requested review from LeoAdamek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasondilworth56 @parasyte