chore: no need thiserror#158
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
houseme
approved these changes
Jan 12, 2026
Contributor
Author
|
cc @LeoBorai for visibility >< |
LeoBorai
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
thiserroris a good crate, inlocal-ip-address's use case, it doesn't seems to be very helpful.Replacing it with manual impl makes the result clear and reduce a proc-macro execution when this is the final usage of proc-macro.