Respond to request for tracking issue on job name validation#36
Closed
Respond to request for tracking issue on job name validation#36
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on IPC for Hub and Store PR review points
Respond to request for tracking issue on job name validation
Jan 18, 2026
LeoBorai
force-pushed
the
31-hub-ipc-for-store
branch
from
202c209 to
e50160d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review comment requested creating a GitHub issue to track the missing validation for job name fields in the create job API endpoint.
Changes
src/cli/src/server/api/v0/jobs/create.rs:15)Context
The job name field currently accepts any string without validation, which was flagged during review of the IPC implementation. The user indicated they were "validating at handler level while poc-ing" and wanted to track proper validation as a separate work item.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.