Respond to review feedback on hardcoded max_retries value#37
Closed
Respond to review feedback on hardcoded max_retries value#37
Conversation
Copilot
AI
changed the title
[WIP] WIP address feedback on IPC implementation for Hub and Store
Respond to review feedback on hardcoded max_retries value
Jan 18, 2026
202c209 to
e50160d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review comment requesting issue creation for the hardcoded
max_retriesvalue in job creation endpoint.Changes
max_retriesconfigurableContext
The
max_retriesvalue atsrc/cli/src/server/api/v0/jobs/create.rs:33is currently hardcoded to 3. Reviewer acknowledged keeping it hardcoded during POC phase but requested tracking issue for future configuration support.Future work will make this configurable via API request or configuration file.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.