Skip to content

Respond to review feedback on hardcoded max_retries value#37

Closed
Copilot wants to merge 16 commits intomainfrom
copilot/sub-pr-32-again
Closed

Respond to review feedback on hardcoded max_retries value#37
Copilot wants to merge 16 commits intomainfrom
copilot/sub-pr-32-again

Conversation

Copy link

Copilot AI commented Jan 18, 2026

Addressed review comment requesting issue creation for the hardcoded max_retries value in job creation endpoint.

Changes

  • Replied to review comment explaining inability to create issues due to permission constraints
  • Provided structured issue template for tracking future work to make max_retries configurable

Context

The max_retries value at src/cli/src/server/api/v0/jobs/create.rs:33 is currently hardcoded to 3. Reviewer acknowledged keeping it hardcoded during POC phase but requested tracking issue for future configuration support.

let job = Job {
    // ... other fields
    retry_count: 0,
    max_retries: 3,  // Currently hardcoded
};

Future work will make this configurable via API request or configuration file.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Jan 18, 2026
Copilot AI changed the title [WIP] WIP address feedback on IPC implementation for Hub and Store Respond to review feedback on hardcoded max_retries value Jan 18, 2026
Copilot AI requested a review from LeoBorai January 18, 2026 14:41
@LeoBorai LeoBorai force-pushed the 31-hub-ipc-for-store branch from 202c209 to e50160d Compare January 18, 2026 14:48
Base automatically changed from 31-hub-ipc-for-store to main January 18, 2026 14:54
@LeoBorai LeoBorai closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants