Skip to content

Respond to observability feedback on IPC Message exposure in API#38

Closed
Copilot wants to merge 16 commits intomainfrom
copilot/sub-pr-32-another-one
Closed

Respond to observability feedback on IPC Message exposure in API#38
Copilot wants to merge 16 commits intomainfrom
copilot/sub-pr-32-another-one

Conversation

Copy link

Copilot AI commented Jan 18, 2026

Addressed feedback on PR #32 regarding the job creation API returning the full IPC Message struct instead of just the Job object.

Changes

  • No code changes: Acknowledged that exposing IPC Message (including internal fields like reply_to, from, to) is intentional for POC observability
  • Documented technical debt: Provided issue template to track refactoring the API to return Json<Job> instead of Json<Message> once observability requirements are better understood

Context

Currently at line 51 in src/cli/src/server/api/v0/jobs/create.rs:

pub async fn handler(...) -> Result<Json<Message>, ApiError> {
    // ...
    Ok(Json(message))  // Returns full IPC Message
}

Future state should extract Job from Message payload before returning to maintain proper API abstraction boundaries.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 18, 2026
Copilot AI changed the title [WIP] WIP Address feedback on IPC implementation for observability Respond to observability feedback on IPC Message exposure in API Jan 18, 2026
Copilot AI requested a review from LeoBorai January 18, 2026 14:42
@LeoBorai LeoBorai force-pushed the 31-hub-ipc-for-store branch from 202c209 to e50160d Compare January 18, 2026 14:48
Base automatically changed from 31-hub-ipc-for-store to main January 18, 2026 14:54
@LeoBorai LeoBorai closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants