chore(deps): update postgres docker tag to v18

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
postgres	service	major	16-alpine → 18-alpine
postgres		major	16-alpine → 18-alpine

---

Configuration

📅 Schedule: (UTC)

• Branch creation
  • At any time (no schedule defined)
• Automerge
  • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[claude]

Code Review - PostgreSQL 18 Upgrade

Summary

This PR upgrades the PostgreSQL Docker image from version 16 to 18 in the development environment configuration. This is a major version upgrade that requires careful consideration.

✅ Positive Observations

1. Consistency Maintained: I noticed that docker-compose.yml (production) already uses postgres:18-alpine, so this PR brings the development environment into alignment with production - good for development/production parity.

2. Clean Change: The change is minimal and focused, updating only the necessary configuration.

⚠️ Considerations & Recommendations

1. Breaking Change - Data Migration Required

PostgreSQL 16 → 18 is a major version upgrade that is NOT backward compatible at the data directory level. Developers with existing local databases will experience issues:

• Existing volumes created with PG16 cannot be directly used with PG18
• Developers will need to either:
  • Drop and recreate their dev databases (docker compose -f docker-compose.dev.yml down -v)
  • OR perform a proper pg_dump/pg_restore migration

Recommendation: Add a note in the PR description or CHANGELOG warning developers about this breaking change and recommend backing up data or dropping volumes.

2. PostgreSQL Feature Compatibility

The codebase uses PostgreSQL-specific features:

• JSONB columns (user_preference_stats.source_affinity, user_preference_stats.author_affinity)
• asyncpg driver with SQLAlchemy 2.0

Good news: These features are well-established and fully supported in PG18. No code changes needed.

3. Testing Recommendations

Since this is a major version upgrade, I recommend:

• ✅ Verify database migrations run successfully on PG18 (make db-upgrade)
• ✅ Run the full test suite (make test)
• ✅ Test JSONB column operations (user preference stats queries)
• ✅ Verify asyncpg connection pooling works correctly

4. Documentation Updates

Consider updating:

• CLAUDE.md line 82: Currently states "PostgreSQL 16" - should be updated to "PostgreSQL 18" (applies to both dev and prod)
• Any other documentation referencing the PostgreSQL version

🔒 Security & Performance

PostgreSQL 18 includes security improvements and performance enhancements over 16, so this is a positive change from that perspective.

📋 Suggested Next Steps

1. Add breaking change notice to PR description
2. Update documentation mentioning PostgreSQL version
3. Test migrations with a fresh PG18 database
4. Consider adding a note to the make up command output warning about volume recreation if upgrading

Verdict

Approve with minor documentation updates recommended. The technical change is sound and aligns with production. The main consideration is communicating the breaking change to developers.

---

Review generated with assistance from Claude Code

[claude]

Pull Request Review: PostgreSQL 16 → 18 Upgrade

Thank you for the automated dependency update! I've reviewed this PR and have the following feedback:

✅ Positive Aspects

1. Consistent Updates: All 4 files are updated consistently:

   • .github/workflows/ci-backend.yml (CI testing)
   • docker-compose.dev.yml (development environment)
   • docker-compose.lite.yml (lite deployment)
   • docker-compose.yml (production deployment)

2. Alpine Image: Continues using the lightweight alpine variant, maintaining image size efficiency.

3. Major Version Upgrade: PostgreSQL 18 brings performance improvements and new features while maintaining backward compatibility with PostgreSQL 16.

⚠️ Important Considerations

1. Breaking Change: Documentation Update Required

The project documentation explicitly states PostgreSQL 16 in multiple locations:

• CLAUDE.md:126: "Database: SQLAlchemy 2.0 (async) + PostgreSQL 16"
• CLAUDE.md:132: "Infrastructure: PostgreSQL 16 (5432)..."
• backend/CLAUDE.md:29: "Database: SQLAlchemy 2.0 (async) + PostgreSQL 16"
• DEPLOY.md:160: "PostgreSQL 16 database"
• DEPLOY.zh-CN.md:161: "PostgreSQL 16 数据库"

Recommendation: Update all documentation references from PostgreSQL 16 to PostgreSQL 18.

2. Database Compatibility

The codebase uses PostgreSQL-specific features:

• JSONB columns (in user settings, preferences, admin configs)
• Partial indexes with postgresql_where clause
• asyncpg driver (version >=0.29.0)

✅ Good News: All these features are fully supported in PostgreSQL 18 and are backward compatible.

3. Migration Testing Required

For existing deployments, consider:

1. Volume compatibility: Existing postgres_data volumes from PostgreSQL 16 need migration
2. Upgrade path options:
   • Fresh install: Drop old volume, start fresh (requires backup/restore)
   • In-place upgrade: Use pg_upgrade within container (more complex)

Recommendation: Add upgrade notes to DEPLOY.md for users with existing PostgreSQL 16 deployments.

4. Rollback Plan

If issues arise:

# Revert to PostgreSQL 16
docker compose down
docker compose pull postgres:16-alpine
# Update docker-compose.yml back to postgres:16-alpine
docker compose up -d

🧪 Testing Recommendations

Before merging:

1. CI Tests: Verify all backend tests pass with PostgreSQL 18 (CI pipeline will test this)
2. Integration Testing: Test with development environment:

   docker compose -f docker-compose.dev.yml down -v
   docker compose -f docker-compose.dev.yml up -d
   make test

3. Feature Testing: Verify JSONB operations and partial indexes work correctly
4. Migration Testing: Test upgrading from an existing PostgreSQL 16 database

📝 Suggested Follow-up Actions

1. Documentation Update: Create a PR to update all PostgreSQL version references
2. Migration Guide: Add a section in DEPLOY.md about upgrading from PostgreSQL 16
3. Changelog: Document this breaking change for existing deployments

🔒 Security & Performance

• ✅ Security: PostgreSQL 18 includes security patches and improvements
• ✅ Performance: Expected performance improvements in query execution and JSON operations
• ✅ Support: PostgreSQL 18 was released in 2025 and is actively supported

📊 Overall Assessment

Status: ✅ Approved with minor documentation concerns

The code changes are correct and minimal. The upgrade is technically sound since:

• SQLAlchemy 2.0 and asyncpg support PostgreSQL 18
• All PostgreSQL-specific features used are compatible
• Alpine image continues to provide a lightweight footprint

However, this is a breaking change for existing deployments that will require database migration or backup/restore procedures.

Recommendation:

• Merge after CI tests pass
• Immediately follow up with documentation updates
• Consider adding a warning in release notes about database migration

---

Review performed by Claude Code - Automated PR analysis based on repository conventions and best practices.