LuisA/258-gift-details-view-fixed-eslint#397
Open
luisarevalo21 wants to merge 28 commits intodevelopfrom
Open
Conversation
luisarevalo21
requested review from
HoldUpFjord,
alexappleget,
jennifertieu,
kepsteen and
shashilo
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kepsteen
requested changes
May 10, 2025
…/LetsGetTechnical/elecretanta into luisA/258-GiftDetailsView-ESLint
nickytonline
requested changes
Jun 29, 2025
Member
nickytonline
left a comment
nickytonline
left a comment
There was a problem hiding this comment.
Looks good. One small change request.
shashilo
requested review from
a team and
bethanyann
and removed request for
a team
Co-authored-by: Nick Taylor <nick@nickyt.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the GiftDetailsView component had several ESlint issues after removing it from the list of ignored files.
After removing it from the ignored list I addressed all the Eslint issues.
closes #258