fix: fixed ESlint errors in ./components/Input/input.tsx#412
Open
luisarevalo21 wants to merge 14 commits intodevelopfrom
Open
fix: fixed ESlint errors in ./components/Input/input.tsx#412luisarevalo21 wants to merge 14 commits intodevelopfrom
luisarevalo21 wants to merge 14 commits intodevelopfrom
Conversation
luisarevalo21
requested review from
HoldUpFjord,
alexappleget,
jennifertieu,
kepsteen and
shashilo
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kepsteen
requested changes
May 16, 2025
Collaborator
kepsteen
left a comment
kepsteen
left a comment
There was a problem hiding this comment.
Build is failing and you included some changes that aren't related to this ticket in the GiftDetailsView.tsx file
kepsteen
requested changes
May 17, 2025
nickytonline
changed the title
nickytonline
approved these changes
Sep 18, 2025
| * @param {string} props.type - type of button | ||
| * @returns {Input} - returns Input Component | ||
| */ | ||
|
|
Member
There was a problem hiding this comment.
nit: remove the space between the JSDoc comments and the variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #265
Was much simpler as React.forwardRef<HTMLInputElement, React.ComponentProps<'input'>> already provides the correct typing to className and types.
Only needed to add the header.