Skip to content

feat #692: Add loading spinner to Submit button CreateGroupPage#700

Draft
tonyb650 wants to merge 1 commit intodevelopfrom
tony/692-loading-spinner
Draft

feat #692: Add loading spinner to Submit button CreateGroupPage#700
tonyb650 wants to merge 1 commit intodevelopfrom
tony/692-loading-spinner

Conversation

@tonyb650
Copy link
Copy Markdown
Contributor

@tonyb650 tonyb650 commented Nov 24, 2025

Description

Before:

No loading spinner when submitting form

After:

"Submit" button is disabled and shows loading spinner while submitting form

Ticket #692

Additional information

I'd like some feedback on my work so far.
Other places where an "onSubmit" spinner could be added are the EditGroupPage and the Onboarding,"Find My Perfect Gift" button.

Screenshots

Loading.spinner.mov

Pre-submission checklist

  • Code builds and passes locally
  • PR title follows Conventional Commit format (e.g. test #001: created unit test for __ component)
  • Request reviews from the Peer Code Reviewers and Senior+ Code Reviewers groups
  • Thread has been created in Discord and PR is linked in gis-code-questions

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elecretanta Ready Ready Preview Comment Nov 24, 2025 4:24pm
elecretanta-storybook Ready Ready Preview Comment Nov 24, 2025 4:24pm
elecretanta-unit-test Ready Ready Preview Comment Nov 24, 2025 4:24pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tony/692-loading-spinner

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@shashilo shashilo requested review from a team and shashilo and removed request for a team November 24, 2025 16:25
@suzuhe481
Copy link
Copy Markdown
Contributor

It looks good. I would say be more specific in naming the loading state. Something like isSubmitting to include the action of the button. It would make it clearer if we ever implement loading states for other things in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants