feat #692: Add loading spinner to Submit button CreateGroupPage#700
feat #692: Add loading spinner to Submit button CreateGroupPage#700
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
|
It looks good. I would say be more specific in naming the loading state. Something like |
Description
Before:
No loading spinner when submitting form
After:
"Submit" button is disabled and shows loading spinner while submitting form
Ticket #692
Additional information
I'd like some feedback on my work so far.
Other places where an "onSubmit" spinner could be added are the EditGroupPage and the Onboarding,"Find My Perfect Gift" button.
Screenshots
Loading.spinner.mov
Pre-submission checklist
test #001: created unit test for __ component)Peer Code ReviewersandSenior+ Code Reviewersgroupsgis-code-questions