QOL Changes

[MohamedKiouaz]

WIP branch where I test many changes

[LiamMorrow]

Thanks for the contribution! Would you be able to split this into two different PRs, one for the stats change and one for the exercise change. After reading a bit of the changes I think we'll be able to get the stats change in without changing too much about it, but we might need to iterate on the exercise change a bit

[MohamedKiouaz]

[LiamMorrow]

Woah that is a SIGNIFICANT rework of the UI. I'll jump ahead here and say I'm not extremely keen for a big ui overhaul at this stage. I went with material UI for a few reasons. Of course feel free to keep playing around with it if you're enjoying yourself!

I'm more likely to accept PRs for smaller more focused changes, but yeah if this is just your exploration branch go wild :) Just setting the scene from my end. I'm definitely open to the spirit of these changes in making more layouts / tabs for history and stats, just would probably want to keep it in material UI 3

[MohamedKiouaz]

I'll revert anything that moves away from the material UI 3.

Indeed this is my fun branch. Those are the changes so far that I can cherry pick to their own branch to be merged.

Does the muscle group feature make sense ? It's an open issue. In the implem I made, the storage has to be changed to store the muscles groups for each exercise, that's the only change that breaks compatibility. I personally would like to know the number of sets per week per muscle group from the app.

Add inline exercise suggestions In this, I remove the need for a click in the add exercise input box, it makes it faster to add exercices

Add bulk exercise rename Because we do not have name autocomplete by default, some exercises I have stored do differ in name and I would like to merge them.

For now, I have a Freeform workout plan with 20+ exercises that I use when I am having a fun session, that's the only solution I found because inputting by hand a quick workout is almost impossible to do on the fly. I don't remove the unused exercises because there is too many. This makes the exported csv uneffective because I cannot differenciate between planned but not done and planned because there is no other way to input effectively.

Add workout progress pill to session footer This is a set counter at the bottom, I think it has been requested, easy to implement but the question is does it look good

Increase workout rep label letter spacing Just GUI but the spacing for the 9/12 reps feels really off.

Add AMOLED theme option To be implement further, this saves battery when the screen is always on (I think it is also requested in an issue)

Fix bug after workout removal When removing an exercise during the workout but not validated as a plan change, the exercise will be reordered to be last. This fixes it

Add workout progress screen with personal bests No storage involved, to be iterated to be nicer.

Show previous reps as workout placeholders instead of showing _/12, show the previous rep count as a light color.

Make workout exercises collapsible cards On an exercise is done, it's no longer useful to show on screen, we can reduce it's size because the user is not expected to interact with it anymore. User can uncollapse at any time. Collapsing does introduce a new button.

Tighten history calendar top spacing I think there is a problem with the spacing, Titles have a top margin that is added to the card padding, creating a lot of wasted space. This reduce the padding (eg not the touch sensitive part)

[LiamMorrow]

Thanks for that. I'll have to find some time to pull this down and look at each thing individually to give you more feedback. Unfortunately I'm in the midst of a move and it's not slowing down so it might take me some time, but rest assured I'll get to it. If it does feel like I've forgotten don't be scared to bump this thread

[LiamMorrow]

Does the muscle group feature make sense ? It's an open issue. In the implem I made, the storage has to be changed to store the muscles groups for each exercise, that's the only change that breaks compatibility. I personally would like to know the number of sets per week per muscle group from the app.

It's definitely been requested. I'm currently redoing the storage a little to make it a bit easier for others to contribute (phasing out protobuf). I'll try get that out so there's not heaps of conflicts

[MohamedKiouaz]

Related to #638, #396, #357, #371, #708

[MohamedKiouaz]

I'll revert anything that moves away from the material UI 3.

Indeed this is my fun branch. Those are the changes so far that I can cherry pick to their own branch to be merged.

Does the muscle group feature make sense ? It's an open issue. In the implem I made, the storage has to be changed to store the muscles groups for each exercise, that's the only change that breaks compatibility. I personally would like to know the number of sets per week per muscle group from the app.

Add inline exercise suggestions In this, I remove the need for a click in the add exercise input box, it makes it faster to add exercices

Add bulk exercise rename Because we do not have name autocomplete by default, some exercises I have stored do differ in name and I would like to merge them.

For now, I have a Freeform workout plan with 20+ exercises that I use when I am having a fun session, that's the only solution I found because inputting by hand a quick workout is almost impossible to do on the fly. I don't remove the unused exercises because there is too many. This makes the exported csv uneffective because I cannot differenciate between planned but not done and planned because there is no other way to input effectively.

Add workout progress pill to session footer This is a set counter at the bottom, I think it has been requested, easy to implement but the question is does it look good

Increase workout rep label letter spacing Just GUI but the spacing for the 9/12 reps feels really off.

Add AMOLED theme option To be implement further, this saves battery when the screen is always on (I think it is also requested in an issue)

Fix bug after workout removal When removing an exercise during the workout but not validated as a plan change, the exercise will be reordered to be last. This fixes it

Add workout progress screen with personal bests No storage involved, to be iterated to be nicer.

Show previous reps as workout placeholders instead of showing _/12, show the previous rep count as a light color.

Make workout exercises collapsible cards On an exercise is done, it's no longer useful to show on screen, we can reduce it's size because the user is not expected to interact with it anymore. User can uncollapse at any time. Collapsing does introduce a new button.

Tighten history calendar top spacing I think there is a problem with the spacing, Titles have a top margin that is added to the card padding, creating a lot of wasted space. This reduce the padding (eg not the touch sensitive part)

Any feedback on this @LiamMorrow?

[LiamMorrow]

Any feedback on this @LiamMorrow?

Sorry for the delay.

Without looking at the code too much or pulling it down to run I'll comment on what I think for each point:

Add inline exercise suggestions In this, I remove the need for a click in the add exercise input box, it makes it faster to add exercices

I'm a little worried that due to the amount of similarly named exercises, the popup list isn't gonna be enough to find all exercises but I haven't seen it. Would you be able to show some screenshots of what it looks like?

Add bulk exercise rename Because we do not have name autocomplete by default, some exercises I have stored do differ in name and I would like to merge them.

I think this is a good idea, and something I've wanted as well. Would love to see an inpedentant PR of this with screenshots

Add workout progress pill to session footer This is a set counter at the bottom, I think it has been requested, easy to implement but the question is does it look good

I wasn't really a fan of this idea when it was suggested I don't think I'll be that keen on it. But feel free to screenshot it. I just think space is at a premium and it's not hard to see how far you are by scrolling.

Increase workout rep label letter spacing Just GUI but the spacing for the 9/12 reps feels really off.

Hmm, I don't know if I agree, maybe it is a device specific thing? 1.5 seems fairly spread out. Do you have a screenshot? This is what I see when I change it to 1.5:

Add AMOLED theme option To be implement further, this saves battery when the screen is always on (I think it is also requested in an issue)

The link here is broken but yeah the idea of an amoled theme is good!

Fix bug after workout removal When removing an exercise during the workout but not validated as a plan change, the exercise will be reordered to be last. This fixes it

Again the link is no longer working I'm afraid.

Add workout progress screen with personal bests No storage involved, to be iterated to be nicer.

Again the link is no longer working I'm afraid. But would this be in the post workout summary?

Show previous reps as workout placeholders instead of showing _/12, show the previous rep count as a light color.

Definitely something I've thought of trying, never tried it. Would love a screenshot / PR I do think we could iterate this one in. My biggest fear is it would be confusing

Make workout exercises collapsible cards On an exercise is done, it's no longer useful to show on screen, we can reduce it's size because the user is not expected to interact with it anymore. User can uncollapse at any time. Collapsing does introduce a new button.

Interesting idea! Would definnitely look at a PR with screenshots to iterate on. Off the top of my head I think it would be fine with a new button if it was in the overflow menu, idk if it needs to always be shown.

Tighten history calendar top spacing I think there is a problem with the spacing, Titles have a top margin that is added to the card padding, creating a lot of wasted space. This reduce the padding (eg not the touch sensitive part)

Yeah that seems fair. IDK what the change is, but changing from marginVertical to marginBottom definitely tightens it up a bit