libertem_dectris: hard upper frame stack size limit in number of frames; optional latency limit#85
Merged
sk1p merged 4 commits intoLiberTEM:mainfrom Jan 19, 2026
Merged
Conversation
a65e3b9 to
574efe6
Compare
084fb57 to
21dbd06
Compare
libertem_dectris: hard upper frame stack size limit in number of frameslibertem_dectris: hard upper frame stack size limit in number of frames; optional latency limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting a frame stack, the internal logic did not have a hard limit on the number of frames per frame stack - this was handled separately in higher level logic.
Now, if one has very small frames (let's say almost all zeros, detector running with beam blanked), the background thread would have a very high latency until it starts to yield data.
This PR changes the behavior to have control over the limits in the background thread:
frame_stack_sizeis now also an upper limit of number of frames, in addition to estimating a slot sizemax_latency_per_stack, to have a built in upper latency limit per frame stack, which is needed for example for good interactivity with "long" frame times (1ms+) without having to set a largeframe_stack_size(so one doesn't need to reallocate shared memory when changingframe_stack_size