docs: document 64x64 and oversize frame dimensions - #454
Open
JackWenStack wants to merge 1 commit into
Open
Conversation
👷 Deploy request for liberatedpixelcup pending review.Visit the deploys page to approve it
|
JackWenStack
had a problem deploying
to
visual-fork
April 27, 2026 03:42 — with 
GitHub Actions
Failure
GitHub Actions
Failure
JackWenStack
marked this pull request as ready for review
April 27, 2026 03:44
Gaurav0
requested changes
Apr 27, 2026
Member
There was a problem hiding this comment.
- Please remove planning documents
- Document frame sizes for all oversize animations.
You can generally find this information in the code.
See the customAnimations array in custom-animations.ts
jrconway3
requested changes
May 7, 2026
| ## Acceptance Criteria | ||
|
|
||
| - [x] The README explicitly states that classic LPC frames are 64x64. | ||
| - [x] The README clarifies that weapon and oversize animations can exceed 64x64 and should be cut/exported with matching larger frame dimensions. |
Contributor
There was a problem hiding this comment.
Like Gaurav said, the planning documents should be removed. These very clearly are in an .auto-pr directory:
[.auto-pr/SPEC.md](https://github.com/LiberatedPixelCup/Universal-LPC-Spritesheet-Character-Generator/pull/454/changes#diff-f5528671d7ba894b18ee1cea277d7bd910a11db14a9cd0116ee514de9b44de7e)
Just add .auto-pr to .gitignore and that will solve the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167 - Document frame sizes
Spec
Spec - Issue #167
Problem
The project documentation does not explicitly tell users that the classic LPC frame size is 64x64 while some weapon and oversize animations require larger frame dimensions.
Acceptance Criteria
Work Breakdown
TODO - Issue #167
Notes
None.
Validation