PROPOSAL: Unique Palette Identifiers - #530
Draft
jrconway3 wants to merge 3 commits into
Draft
Conversation
✅ Deploy Preview for liberatedpixelcup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed some palettes to make them more clear what they are if we include all palettes in a new "all_ulpc.json" sheet (#528). The idea here is to bring it inline with LPCR palettes:
I implemented a forwarding system, but I haven't tested it yet, and I feel like it won't work anyway.
This is only a draft for now because I don't want to implement palette renames without a ton of scrutiny first.
I also opened a discussion page:
#534