Nodejs typescript migration part 2 - #564
Open
Gaurav0 wants to merge 16 commits into
Open
Conversation
Keep the sheet-definition restore CLI ignored by Codecov after the rename. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop unused execSync callbacks that Node never invoked so the CLI type-checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Use fs.rmSync for recursive folder removal so the ImageMagick compose CLI type-checks on current Node types. Co-authored-by: Cursor <cursoragent@cursor.com>
Scan .ts sources as well as leftover .js so the PurgeCSS hint CLI still finds class names. Co-authored-by: Cursor <cursoragent@cursor.com>
Point Testem at the renamed merger and add ambient types for untyped Istanbul report packages. Co-authored-by: Cursor <cursoragent@cursor.com>
Point fixture-builder at the renamed Playwright golden capture so regeneration still works. Co-authored-by: Cursor <cursoragent@cursor.com>
Import the default ZIP profile hash from the renamed module in both profile runners. Co-authored-by: Cursor <cursoragent@cursor.com>
Point the npm zip-profile diff script at the renamed CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Point profile:zip npm scripts at the renamed Playwright ZIP timing CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat the browser harness as a DOM script in ESLint and load the renamed module from the profile HTML page. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep emitting JavaScript fixtures and point fixture:issue382 at the renamed builder CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Unblock computed-style tooling and keep the visual homepage spec importing the renamed helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep Playwright page callbacks free of type syntax so Node can serialize them into the browser. Co-authored-by: Cursor <cursoragent@cursor.com>
Point compute-style-dump npm scripts at the renamed Playwright dump CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Point compute-style-diff-all npm scripts at the renamed multi-preset dump CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for liberatedpixelcup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of the typescript migration of nodejs files.
There will be a part 3 and possibly a part 4.