add capability and option flag to treat int96 as a timestamp #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4ys0n
changed the title
shannonwells
requested changes
Mar 17, 2025
| this.timeout(30000); // Increase timeout for URL fetching | ||
|
|
||
| const testUrl = | ||
| 'https://aws-public-blockchain.s3.us-east-2.amazonaws.com/v1.0/eth/traces/date%3D2016-05-22/part-00000-54f4b70c-db10-479c-a117-e3cc760a7e26-c000.snappy.parquet'; |
There was a problem hiding this comment.
Please change this to read in a small reference file (<10-20kb) that is checked into test/test-files, with or without an S3 mock client as in test/reader.js
Author
There was a problem hiding this comment.
yeah.. i don't have this. i have that file. thousands of them, actually. 🙃
but, on the bright side, at least i wrote tests this time! 😄
There was a problem hiding this comment.
well, if you can truncate one of your files and check it into the PR that'd be much appreciated. if that's not possible let us know.
shannonwells
requested changes
Mar 17, 2025
auto-merge was automatically disabled
March 18, 2025 01:41
Head branch was pushed to by a user without write access
shannonwells
approved these changes
May 13, 2025
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
We need this change so I'm approving and will set an issue to add a small test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's currently no way to handle INT96 timestamps.
Closes #158
Solution
add a flag to enable treating all INT96 fields in a file as timestamps.
Change summary:
Steps to Verify:
npm test -- -g "INT96 timestamp handling"INT96 timestamp handling ✔ should handle INT96 values as numbers by default (4593ms) block_timestamp timestamp: 2016-05-22T08:22:02.000Z last_modified timestamp: 2022-09-12T01:05:04.629Z ✔ should convert INT96 values to timestamps when option is enabled (3125ms)