Fix Metadata Statistics Comparison #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct test for issue
wilwade
force-pushed
the
fix/metadata-buffer-comp-137
branch
from
73015a5 to
b806f0d
Compare
shannonwells
approved these changes
Aug 20, 2025
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
I reviewed the code and added a test, and added Date type to the comparator. Looks good to go.
| throw new Error('Unsupported time unit'); | ||
| } | ||
|
|
||
| export function isUint8Array(x: unknown): x is Uint8Array { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Buffers were not correctly being compared causing incorrect statistics.
Closes #137
Solution
Added buffer comparison separately from other
>/<for statistics.Change summary:
compareStatisticswhich uses bothcompareStatisticsGtLtand what actually does the fixcompareStatisticsBufferSteps to Verify: