Skip to content

Update dockerfile to build #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicholasmello
Copy link

Can be run with the commands:

docker build -t liberty .
docker run -v $(pwd):/mnt -ti liberty

Can be run with the commands:

docker build -t liberty .
docker run -v $(pwd):/mnt -ti liberty

Signed-off-by: Nicholas Mello <[email protected]>
@nicholasmello
Copy link
Author

nicholasmello commented Jul 9, 2023

Fix for issue #5

@danielteberian
Copy link
Contributor

Full disclosure: I am not very good at using Docker. I understand how it works, what it is for, and why it would be good to have for the kernel, but I could never get Docker to work on my computer.

What would the user need to do in order to set up the OS using Docker? Could we create a file to explain how to use Docker with the kernel?

@nicholasmello
Copy link
Author

Once docker is installed it is as simple as running those 2 commands. What docker issues specifically were you running into? I might be able to help out. I haven't tried anything on Windows but I do have a Windows computer (I develop on KDE Neon) and I suspect the second command will work in powershell. I can write up a document with links to setting up docker on different operating systems as well as these commands that you need to run.

docker build -t liberty .
Sets up the environment and builds the image

docker run -v $(pwd):/mnt -ti liberty
Runs the copy script to copy the target folder into the target folder in the directory you are in.

Looking at that failed build, the warnings look to be related to me bumping the version to a newer version, I can make those fixes.

Fixed the warnings about features being sable
Moved the copy of files lower down in the script so less is needed on rerun

Signed-off-by: Nicholas Mello <[email protected]>
@danielteberian
Copy link
Contributor

If you can set that all up, go for it. Could I merge this request?

@nicholasmello nicholasmello marked this pull request as ready for review July 11, 2023 01:30
@nicholasmello
Copy link
Author

Yeah I can do that as a separate request and we can get this merged in

@danielteberian
Copy link
Contributor

Hooplah!

@danielteberian
Copy link
Contributor

What's the status for this PR? I would love to merge it, but I am not sure if you were finished working on it.

@davethiede davethiede mentioned this pull request Jul 12, 2023
@davethiede
Copy link
Contributor

i pushed a PR that seems to have failed tests trying to run bootimage. the container itself doesn't seem to need it. not seeing what I missed so far. Pretty new to this level of embedded development.

@davethiede
Copy link
Contributor

Apparently there is an issue with the test runner environment/configuration. all PR being pushed are failing on the test phase including from danielteberian. Something with getting the bootimage command installed correctly? Any ideas?

@danielteberian
Copy link
Contributor

Apparently there is an issue with the test runner environment/configuration. all PR being pushed are failing on the test phase including from danielteberian. Something with getting the bootimage command installed correctly? Any ideas?

If you are referring to the tests that are run by Github, they have never worked. If I remember correctly, the tests do not work without the standard library for Rust, but I could be mistaken. Perhaps I should just stop Github from automatically testing each version that is pushed to the repository. Don't be alarmed about the tests failing. If the kernel does not compile, then we have reason to be worried. As of right now, the kernel compiles without any warnings, so that is good.

If you are referring to "cargo test", then there is a longer explanation to be given. The kernel does have tests, but they have to be executed individually. For some reason, "cargo test" causes an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants