-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build system: use cmake "Release" build type for target / add PKG_BUILD_FLAGS="-ndebug" option #6422
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had missing the request to review / approve.
Once this is pulled in |
@mglae - can we please split this into a ndebug PR and this “release” PR. |
@heitbaum Possible, but the intention was to only require one rebuild for two build system changes. |
…ge media-driver (unnecessary) requirement. Should not affect any other package.
14c867a
to
ca7734c
Compare
Rebased. |
I’m happy with this, I’ve been running this in my dev tree. Ok to merge? |
cmake "Release"
Fulfill package media-driver (unnecessary) requirement to force "Release" build type (but
they do allow uncommon "ReleaseInternal"). Complete #6413.
Should not affect any other package.
Note: to test individual packages without a clean build remove ${BUILD_DIR}/toolchain/etc/cmake*.conf
PKG_BUILD_FLAGS="-ndebug"
There are a few packages not allowing to use -DNDEBUG, namely wayland and weston. Add a
convenient build option to remove the macro.
Test
Clean build and runtime test with Generic/x11. Build tested with Generic/wayland.