build system: use cmake "Release" build type for target / add PKG_BUILD_FLAGS="-ndebug" option #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heitbaum
approved these changes
Jun 25, 2022
heitbaum
approved these changes
Jun 25, 2022
|
Once this is pulled in |
|
@mglae - can we please split this into a ndebug PR and this “release” PR. |
|
@heitbaum Possible, but the intention was to only require one rebuild for two build system changes. |
…ge media-driver (unnecessary) requirement. Should not affect any other package.
mglae
force-pushed
the
le11_build_release_ndebug
branch
from
14c867a to
ca7734c
Compare
|
Rebased. |
|
I’m happy with this, I’ve been running this in my dev tree. Ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake "Release"
Fulfill package media-driver (unnecessary) requirement to force "Release" build type (but
they do allow uncommon "ReleaseInternal"). Complete #6413.
Should not affect any other package.
Note: to test individual packages without a clean build remove ${BUILD_DIR}/toolchain/etc/cmake*.conf
PKG_BUILD_FLAGS="-ndebug"
There are a few packages not allowing to use -DNDEBUG, namely wayland and weston. Add a
convenient build option to remove the macro.
Test
Clean build and runtime test with Generic/x11. Build tested with Generic/wayland.