Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build system: use cmake "Release" build type for target / add PKG_BUILD_FLAGS="-ndebug" option #6422

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mglae
Copy link
Contributor

@mglae mglae commented Apr 23, 2022

cmake "Release"

Fulfill package media-driver (unnecessary) requirement to force "Release" build type (but
they do allow uncommon "ReleaseInternal"). Complete #6413.

Should not affect any other package.

Note: to test individual packages without a clean build remove ${BUILD_DIR}/toolchain/etc/cmake*.conf

PKG_BUILD_FLAGS="-ndebug"

There are a few packages not allowing to use -DNDEBUG, namely wayland and weston. Add a
convenient build option to remove the macro.

Test

Clean build and runtime test with Generic/x11. Build tested with Generic/wayland.

Copy link
Contributor

@heitbaum heitbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had missing the request to review / approve.

@heitbaum
Copy link
Contributor

@heitbaum
Copy link
Contributor

heitbaum commented Oct 8, 2022

@mglae - can we please split this into a ndebug PR and this “release” PR.
No reason why the ndebug commits can’t be committed, as this is cleanup.

@mglae
Copy link
Contributor Author

mglae commented Oct 8, 2022

@heitbaum Possible, but the intention was to only require one rebuild for two build system changes.

@heitbaum heitbaum added LE 12.0 and removed LE 11.0 labels Jan 18, 2023
@CvH CvH added LE 13.0 and removed LE 12.0 labels Mar 12, 2024
@mglae mglae force-pushed the le11_build_release_ndebug branch from 14c867a to ca7734c Compare October 19, 2024 09:45
@mglae
Copy link
Contributor Author

mglae commented Oct 19, 2024

Rebased.

@heitbaum
Copy link
Contributor

I’m happy with this, I’ve been running this in my dev tree. Ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants