-
Notifications
You must be signed in to change notification settings - Fork 20
Generate QFN packages #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hephaisto
wants to merge
62
commits into
LibrePCB:master
Choose a base branch
from
hephaisto:generate-qfn-packages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
19672bc
Add UuidCache class
hephaisto e0cb1a7
Check for stale UUIDs
hephaisto 9bcbd1e
Load context in cache constructor, disable creation without context
hephaisto 7e7577f
Update readme
hephaisto f4bc696
Update generate_axial_tht
hephaisto eb1c1dd
update generate_capacitor_radial_tht.py
hephaisto b789fe3
Update generate_connectors.py
hephaisto 511884a
Update generate_dip.py
hephaisto 4c1569b
Fix model global variable in generate_dip_switches
hephaisto b88dc19
Update generate_dip_switches.py
hephaisto 449e117
Update generate_do.py
hephaisto af6fd8a
Update generate_led.py
hephaisto 70c43fe
Update generate_mosfet_dual.py
hephaisto 6c93a64
Update generate_dpak.py
hephaisto b34496d
Update generate_qfp.py
hephaisto 2829896
Update generate_mounting_holes.py
hephaisto fdb0978
Update generate_dfn.py
hephaisto ee29dc3
Update generate_so.py
hephaisto f683120
Prepare generate_sod.py
hephaisto ef65c2c
Update generate_sod.py
hephaisto 493800d
Fix global variable in generate_tactile_switches
hephaisto 065ae90
Update generate_tactile_switches.py
hephaisto fcbaa09
Update generate_screw_terminals.py
hephaisto aa13198
Update generate_molex_picoblade.py
hephaisto 456ad50
Update generate_chip.py, add create parameter to get
hephaisto 948a9ad
Update generate_jst_sh_connectors.py
hephaisto 2ae21b7
Update generate_idc.py
hephaisto 63827c1
Update generate_modules.py
hephaisto 755b651
Update generate_stm_mcu.py
hephaisto f8c8347
Directly call cache in generate_capacitor_radial_tht.py
hephaisto 571d7e6
Directly call cache in generate_axial_tht.py
hephaisto ee55848
Directly call cache in generate_dip.py
hephaisto 54b7bf6
Directly call cache in generate_connectors.py
hephaisto a8cbeec
Directly call cache in generate_dip_switches.py
hephaisto f819179
Directly call cache in generate_do.py
hephaisto 93161b5
Directly call cache in generate_led.py
hephaisto 577e4fe
Directly call cache in generate_mosfet_dual.py
hephaisto fede54f
Directly call cache in generate_dpak.py
hephaisto 8c28e4e
Directly call cache in generate_mounting_holes.py
hephaisto cf317ff
Directly call cache in generate_qfp.py
hephaisto d794970
Directly call cache in generate_dfn.py
hephaisto 2ca5d98
Directly call cache in generate_screw_terminals.py
hephaisto 592bef6
Directly call cache in generate_so.py
hephaisto 014d58a
Directly call cache in generate_sod.py
hephaisto ef9ad68
Directly call cache in generate_tactile_switches.py
hephaisto 2c052ed
Directly call cache in generate_molex_picoblade.py
hephaisto 5e54244
Directly call cache in generate_jst_sh_connectors.py
hephaisto 207771a
Directly call cache in generate_chip.py
hephaisto 250de0c
Directly call cache in generate_idc.py
hephaisto 8f25e2a
Directly call cache in generate_stm_mcu.py
hephaisto 3e86ab5
Temporarily fix casadi version
hephaisto 6d62b44
Remove manual check for stale uuids
hephaisto b413a2f
Add QFN generator
hephaisto 6ea5fa3
Check for duplicates
hephaisto 022c577
Check consistency of E/D with size x/y
hephaisto 9cfab93
Use x/y for exposed pad sizes
hephaisto 56f1067
print package names
hephaisto 45119ed
Naming according to footprint expert guideline
hephaisto 3558384
Use SubCache
hephaisto f8b6347
Grid solderpaste
hephaisto 89bfcb0
Better formatting
hephaisto 74412c7
Add cache
hephaisto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to factor out this functionality into a common class 👍 However, to keep all scripts consistent (not leaving behind inconsistent concepts which drift apart more and more), honestly I'd highly prefer if you also adjust all the existing generators to make use of this new
UuidCache. This will make future maintenance much easier.Also I guess the functions
init_cache()andsave_cache()would be part of that class then, which would make the code cleaner.In addition, since this change is not related to the new QFN generator, could you please move this into a separate PR?
If you don't want to go this (harder) way for now, I'd propose to just use
init_cache()andsave_cache()in the QFN generator.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#183