Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mantine 7 #529

Draft
wants to merge 52 commits into
base: dev
Choose a base branch
from
Draft

Upgrade to Mantine 7 #529

wants to merge 52 commits into from

Conversation

sickelap
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@derneuere
Copy link
Member

This line here is the reason the FaceDashboard breaks:
https://github.com/sickelap/librephotos-frontend/blob/3232ef927f5e64405b2c9395d5513dfcec4e68c9/src/layouts/dataviz/FaceDashboard.tsx#L338

If you replace flexGrow with width and height, then it works. Maybe that helps debugging it!

@derneuere
Copy link
Member

This is just my notepad, finding all the new inconsistencies:

Before:
image
After (action buttons moved different background header, scrubber empty names and background images):
image

Before:
image
After (buttons moved, also suddenly blue):
image

Before:
image

After (buttons moved, flexgrow broke, scrollscrubber missing):
image

@derneuere
Copy link
Member

It looks great overall! Once the high-priority tasks are addressed, I think we're ready to merge. Everything seems fixable. 👍 Fantastic work!

It would be really helpful if you could document any inconsistencies with screenshots—both before and after fixes. This way, we can easily track changes and avoid confusion about what still needs attention post-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants