Fix/remixer numbering - #913
Merged
Merged
Conversation
…el auto-scrolling behavior
…rove content template selection
jakeaturner
force-pushed
the
fix/remixer-numbering
branch
from
August 18, 2026 20:44
f57bf21 to
f69c9df
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets Remixer page numbering/slug behavior and improves publish/start-over UI interactions, while also refactoring how article types/templates are chosen based on page placement.
Changes:
- Adjusts remixer path-segment numbering padding logic (including dotted numbering) and expands skip logic for certain page states.
- Refactors article kind/template selection (topic-category/topic-guide/topic) and applies it during new/import/move flows.
- Improves client UX: start-over pending state handling, publish log auto-scroll behavior, and title sanitization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| server/util/remixerutils.ts | Updates remixer path segment numbering padding + expands/adjusts skip rules. |
| server/api/services/remixer-service.ts | Refactors article-kind/template selection; modifies publish job processing logic. |
| client/src/components/remixer/RemixerDashboard.tsx | Uses mutation pending state to disable/hide book tree during “Start Over”. |
| client/src/components/remixer/PublishPanel.tsx | Adds “sticky to bottom unless user scrolls up” behavior for publish messages. |
| client/src/components/remixer/EditPanel.tsx | Changes how colons are handled when sanitizing titles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
61
to
+68
| // Prefer formattedPath so autoNumbering `start` (incl. 0 → `00%3A_…`) is honored. | ||
| const numbering = | ||
| page.formattedPath?.trim() || page.numberedPath?.trim() || ""; | ||
| return numbering | ||
| ? `${numbering.padStart(2, "0")}:_${titleSegment}${siblingTitleIndexPostfix}` | ||
| page.numberedPath?.trim() ||page.formattedPath?.trim() || ""; | ||
| const parts = numbering.split("."); | ||
| if (parts.length > 0) { | ||
| parts[parts.length - 1] = parts[parts.length - 1]!.padStart(2, "0"); | ||
| } | ||
| const paddedNumbering = numbering ? parts.join(".") : ""; |
Comment on lines
133
to
+138
| export const shouldSkipPage = (page: RemixerSubPageState, inMatterBranch: boolean, status: RemixerPageStatus): boolean => { | ||
| const pathLen = page.pathNumber?.length ?? 0; | ||
| const isBookRoot = pathLen === 0; | ||
| return isBookRoot || inMatterBranch || status === "unchanged"; | ||
| const pageStatus = getPageStatus(page); | ||
| const isDeleteNoExisting = page.isDeleted && (pageStatus === "imported" || pageStatus === "new") || false; | ||
| return isBookRoot || inMatterBranch || status === "unchanged" || isDeleteNoExisting; |
| autoNumbering, | ||
| ); | ||
|
|
||
| console.log("title", title); |
Comment on lines
1526
to
1530
| if (status === "new") { | ||
| if(shouldSkip) { | ||
| return "success"; | ||
| } | ||
| const parentId = page.parentID ?? "-1"; |
Comment on lines
1553
to
1557
| } else if (status === "imported") { | ||
| if(shouldSkip) { | ||
| return "success"; | ||
| } | ||
| const parentId = page.parentID ?? "-1"; |
Comment on lines
+33
to
+39
| let s = value; | ||
| if (!allowColon) { | ||
| const colonIdx = value.indexOf(":"); | ||
| if (colonIdx !== -1) { | ||
| s = value.slice(colonIdx + 1); | ||
| } | ||
| } |
jakeaturner
approved these changes
Aug 18, 2026
Collaborator
|
🎉 This PR is included in version 2.146.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.