Skip to content

fix(dashboard): template picker defensive fixes (handleApply + vacuous-truth) #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasinBursali wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix(dashboard): template picker defensive fixes (handleApply + vacuous-truth) #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccca57d
fix(dashboard): early-return 'available' for empty-services templates
yasinBursali Apr 23, 2026
479ec12
fix(dashboard): surface JSON parse errors in TemplatePicker handleApply
yasinBursali Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dream-server/extensions/services/dashboard/src/components/TemplatePicker.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export function TemplatePreview({ template, onClose, onApplied }) {
timeout: 120000,
})
if (!res.ok) throw new Error(`HTTP ${res.status}`)
const data = await res.json().catch(() => ({}))
const data = await res.json()
if (data.enabled_count > 0) {
setApplied(data.restart_required ? 'restart_required' : 'enabled')
} else {
Expand Down
1 change: 1 addition & 0 deletions dream-server/extensions/services/dashboard/src/lib/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const BASE_COMPOSE_SERVICES = new Set(['llama-server', 'open-webui', 'das
// Precedence: has_errors > in_progress > applied > available
export function getTemplateStatus(template, extensions) {
const services = template.services || []
if (services.length === 0) return 'available'
const serviceStatus = {}
for (const svcId of services) {
if (BASE_COMPOSE_SERVICES.has(svcId)) {
Expand Down
Loading