Skip to content

docs(security): Linux host-agent fallback is 127.0.0.1 post-#988#1017

Draft
yasinBursali wants to merge 3 commits intoLight-Heart-Labs:mainfrom
yasinBursali:docs/security-md-linux-fallback
Draft

docs(security): Linux host-agent fallback is 127.0.0.1 post-#988#1017
yasinBursali wants to merge 3 commits intoLight-Heart-Labs:mainfrom
yasinBursali:docs/security-md-linux-fallback

Conversation

@yasinBursali
Copy link
Copy Markdown
Contributor

⚠️ Draft — depends on #988 AND #973 merging first

Once both merge, I'll rebase and the PR diff will show exactly the 1-line change below.

What

One-cell docs edit in the "Host Agent Network Binding" table in dream-server/SECURITY.md, Linux row:

- | Linux | auto-detected | Detects the Docker bridge gateway IP (e.g. `172.17.0.1`) so containers can reach the agent; LAN devices cannot. Falls back to `0.0.0.0` if detection fails. |
+ | Linux | auto-detected | Detects the Docker bridge gateway IP (e.g. `172.17.0.1`) so containers can reach the agent; LAN devices cannot. Falls back to `127.0.0.1` if detection fails. |

Why

#973's Linux row was accurate when written but becomes stale the moment #988 merges. Actual runtime behavior per bin/dream-host-agent.py:2241: bind_addr = _detect_docker_bridge_gateway() or "127.0.0.1". Docs should match.

Testing

Platform Impact

  • All three: docs read identically. Linux row describes Linux-specific behavior.

@yasinBursali
Copy link
Copy Markdown
Contributor Author

Re-marking as draft as a mechanical merge-order safeguard.

This branch contains commits ba556a9f and a6350e45 from #973 (docs-sync). Merging this PR before #973 lands would bring #973's content in as a side-effect rather than on its own merit.

Merge order: #973 first, then this PR rebases clean and gets re-marked ready.

@Lightheartdevs
Copy link
Copy Markdown
Collaborator

Audit follow-up: keep draft and rebase to a docs-only delta.

#988 has now landed, so the security-doc direction is right, but this branch is currently draft/conflicting and still carries part of the old code/docs stack. Please rebase on current main and keep only the documentation changes that remain necessary after #988.

yasinBursali and others added 3 commits April 29, 2026 04:11
Fix stale, contradictory, and missing documentation identified by a
systematic audit of the last 50 merged PRs against all existing docs.

Fixes:
- WINDOWS-QUICKSTART.md: remove "Coming Soon" language, add real
  install flow, commands, and verified installer flags
- MODE-SWITCH.md: add lemonade mode section (auto-configured on AMD)
- QUICKSTART.md / README.md: update all Qwen2.5 model names to
  Qwen3.5/Qwen3 to match current tier-map.sh
- POST-INSTALL-CHECKLIST.md: rewrite skeleton with real verification
  commands
- Root README.md: fix Apple Silicon "4B" → "9B" for 16-24GB tier

Additions:
- SECURITY.md: DREAM_AGENT_BIND / LAN access section
- FAQ.md: backup/restore, service templates, bootstrap fast-start,
  expanded update/rollback documentation
- HOST-AGENT-API.md: Windows platform limitation note
- CATALOG.md: add missing Langfuse entry
- Langfuse README.md: new service README with full configuration,
  env vars, volumes, and troubleshooting
- .env.example: document LLAMA_CPU_LIMIT for macOS/CPU-only mode
- SUPPORT-MATRIX.md: link to AMD system-tuning guide

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… on Windows

The prior commit in this PR added two Windows entries to HOST-AGENT-API.md
based on the docs state at the time the sync was drafted. Windows host
agent support shipped via the fix/windows-host-agent-startup branch
before this PR's work began, so the 'not yet available' row and the
'dream.ps1 restart' workaround blockquote describe out-of-date behavior.

Replaces the table row with the accurate mechanism and removes the
workaround blockquote.
…rt-Labs#988

fix/security-loopback (Light-Heart-Labs#988) changes the Linux Docker-bridge-gateway
detection fallback in bin/dream-host-agent.py from 0.0.0.0 to
127.0.0.1 (security fix: prevents LAN exposure when bridge detection
fails). docs/sync-documentation-with-codebase (Light-Heart-Labs#973) adds the Host
Agent Network Binding table whose Linux row documented pre-Light-Heart-Labs#988
behavior — the 0.0.0.0 fallback language is now stale.

Updates the Linux row to match the actual fallback.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yasinBursali yasinBursali force-pushed the docs/security-md-linux-fallback branch from afea9cc to ce676b9 Compare April 29, 2026 01:12
@yasinBursali
Copy link
Copy Markdown
Contributor Author

Pushed audit follow-up — rebased onto current upstream/main.

The audit ("rebase to a docs-only delta after #988") needed clarification because of an interaction with the still-open #973: SECURITY.md on current upstream/main does not yet contain the "Host Agent Network Binding" table at all (#973 introduces it). So a "docs-only delta" rebase resolves to one of two paths:

If #973 merges before this PR, the rebase will trivially collapse the first two commits (their SECURITY.md additions are already on main) and leave just the 1-line correction on the third commit (ce676b99). If this PR merges first, #973's later rebase will need a small SECURITY.md hunk reconciliation (it would otherwise re-add the table with the stale 0.0.0.0 value).

Suggested merge order to minimise rebase friction: #973 first, then #1017. I will update #973 in this same session to use 127.0.0.1 directly, so the 0.0.0.0-stale-cell mismatch never reaches main. After that, #1017 may simply be closed as redundant — happy to close it with a one-line note pointing at the #973 update if you'd prefer that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants