Skip to content

test(dashboard-api): cover SHIELD_API_KEY early-return in /privacy-shield/stats #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yasinBursali wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(dashboard-api): cover SHIELD_API_KEY early-return in /privacy-shield/stats #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions dream-server/extensions/services/dashboard-api/tests/test_privacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,3 +258,29 @@ def test_privacy_shield_stats_connection_error(test_client):
data = resp.json()
assert "error" in data
assert data["enabled"] is False


def test_privacy_shield_stats_missing_shield_key(test_client, monkeypatch):
"""GET /api/privacy-shield/stats when SHIELD_API_KEY is unset short-circuits before any HTTP call."""
monkeypatch.delenv("SHIELD_API_KEY", raising=False)
session_factory = MagicMock()

with patch("routers.privacy.aiohttp.ClientSession", session_factory):
resp = test_client.get("/api/privacy-shield/stats", headers=test_client.auth_headers)

assert resp.status_code == 200
assert resp.json() == {"error": "SHIELD_API_KEY not configured", "enabled": False}
session_factory.assert_not_called()


def test_privacy_shield_stats_empty_shield_api_key(test_client, monkeypatch):
"""GET /api/privacy-shield/stats when SHIELD_API_KEY is empty string short-circuits before any HTTP call."""
monkeypatch.setenv("SHIELD_API_KEY", "")
session_factory = MagicMock()

with patch("routers.privacy.aiohttp.ClientSession", session_factory):
resp = test_client.get("/api/privacy-shield/stats", headers=test_client.auth_headers)

assert resp.status_code == 200
assert resp.json() == {"error": "SHIELD_API_KEY not configured", "enabled": False}
session_factory.assert_not_called()
Loading