chore: apply black formatting baseline#177
chore: apply black formatting baseline#177bugman-007 wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Conversation
This establishes a formatting baseline before adding black to pre-commit hooks. All Python files in dream-server/ have been formatted with black --line-length=100
Addresses review feedback on PR Light-Heart-Labs#178. The statement about all Python files being formatted with black is only true after PR Light-Heart-Labs#177 merges. Removed the premature claim to avoid misleading contributors
Lightheartdevs
left a comment
There was a problem hiding this comment.
Review: ⚠️ NEEDS DISCUSSION — Clean formatting, wrong timing
The formatting itself is correct
Verified the entire diff line by line. This is pure formatting — no logic or behavioral changes. Black defaults (88 char line, double quotes, magic trailing comma). All 14 files are Python source. No test files touched. Ruff lint passes, confirming no conflicts.
The problem is timing and coordination
This PR touches 14 Python files across 3 services. There are 21 other open PRs, and several touch the exact same files (#181, #137, #136, #125, #134, #150). Black reformats entire function bodies, so the merge conflicts will be pervasive — not simple one-line diffs but entire block reshuffles that git cannot auto-merge.
Every open PR that modifies any of these 14 files will need to rebase after this lands.
Missing: `pyproject.toml` with Black config
Black was run with defaults, but there is no committed config file. Without it, the baseline is not reproducible — future contributors may use different settings. This PR should include:
```toml
[tool.black]
line-length = 88
target-version = ["py311"]
```
Recommendation
- Do not merge yet. Merge the high-value PRs first (security fixes, Apple Silicon fixes, features that are close to ready), then land this as a cleanup step when the queue is smaller.
- Add `pyproject.toml` with `[tool.black]` config so the baseline is reproducible.
- Coordinate with PR #178 (pre-commit hooks) — they should land together so formatting is enforced the moment it's established.
- Give contributors 24-48 hours notice before landing. A formatting baseline that drops unannounced generates frustration and wasted rebase effort.
CI note
9 of 15 checks failing. Even if pre-existing, merging with red CI adds noise. Investigate before merge.
|
Closing — draft formatting-only PR that's been sitting for 5 days. If you'd like to pursue this, please rebase and re-open when ready. |
…ible badges
Add title attributes to status badges so users understand what they mean.
Core badge: "Built-in service — managed by DreamServer" with cursor-help.
Incompatible badge: "Requires {gpu_backends} — your system: {gpuBackend}"
so users immediately see the hardware mismatch.
Thread catalog.gpu_backend from the Extensions component down to
ExtensionCard and DetailModal. In the card footer, prefix GPU backend
chips with a "Requires:" label for incompatible extensions. In the
detail modal, show an orange "Your system: {gpuBackend}" subtitle in
the GPU info cell when the extension is incompatible.
Closes Light-Heart-Labs#177
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ible badges
Add title attributes to status badges so users understand what they mean.
Core badge: "Built-in service — managed by DreamServer" with cursor-help.
Incompatible badge: "Requires {gpu_backends} — your system: {gpuBackend}"
so users immediately see the hardware mismatch.
Thread catalog.gpu_backend from the Extensions component down to
ExtensionCard and DetailModal. In the card footer, prefix GPU backend
chips with a "Requires:" label for incompatible extensions. In the
detail modal, show an orange "Your system: {gpuBackend}" subtitle in
the GPU info cell when the extension is incompatible.
Closes Light-Heart-Labs#177
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ible badges
Add title attributes to status badges so users understand what they mean.
Core badge: "Built-in service — managed by DreamServer" with cursor-help.
Incompatible badge: "Requires {gpu_backends} — your system: {gpuBackend}"
so users immediately see the hardware mismatch.
Thread catalog.gpu_backend from the Extensions component down to
ExtensionCard and DetailModal. In the card footer, prefix GPU backend
chips with a "Requires:" label for incompatible extensions. In the
detail modal, show an orange "Your system: {gpuBackend}" subtitle in
the GPU info cell when the extension is incompatible.
Closes Light-Heart-Labs#177
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This establishes a formatting baseline before adding black to pre-commit hooks. All Python files in dream-server/ have been formatted with black --line-length=100