Fix section-aware config parsing, document security flags#3
Merged
Lightheartdevs merged 2 commits intomainfrom Feb 17, 2026
Merged
Fix section-aware config parsing, document security flags#3Lightheartdevs merged 2 commits intomainfrom
Lightheartdevs merged 2 commits intomainfrom
Conversation
…ded .gitignore Prevents agents and contributors from accidentally committing secrets: - .pre-commit-config.yaml: gitleaks + detect-private-key hooks (local) - .github/workflows/secret-scan.yml: gitleaks action on PRs and pushes (CI) - .gitignore: global patterns for .env, keys, certs, credentials, keystores Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Critical bug fix: parse_yaml()/Parse-Yaml matched the first occurrence of a key name globally, so duplicate keys like 'enabled', 'port', 'host' across session_cleanup/tool_proxy/token_spy sections would silently return the wrong section's value. Now uses "section.key" format (e.g., "token_spy.enabled") to scope lookups within YAML sections. Also: - Document dangerouslyDisableDeviceAuth and allowInsecureAuth in README - Add RepetitionDuration to Windows cleanup timer for reliability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
igorls
referenced
this pull request
in igorls/DreamServer
Mar 9, 2026
Shell Scripts: - dream-restore.sh: Replace hardcoded config list with dynamic glob for compose overlays (.base.yml, .nvidia.yml, etc.) (Light-Heart-Labs#4) - dream-update.sh: Use resolve-compose-stack.sh for container restart instead of hardcoded docker-compose.yml (Light-Heart-Labs#7) - dream-update.sh: Enable dotglob in rollback to restore hidden files like .env and .version (Light-Heart-Labs#6) - dream-backup.sh: Include .tar.gz archives in retention/list queries to prevent infinite disk accumulation (Light-Heart-Labs#9) - dream-backup.sh: Dynamic glob for config backup (compose overlays) Token Spy: - compose.yaml: Add persistent volume mount for data/ directory to prevent SQLite data loss on container restart (#2) - main.py: Offload blocking SSH subprocess to thread pool via asyncio.to_thread() to prevent event loop deadlock (#3) - main.py: Add finally blocks in streaming generators to guarantee billing metrics are logged on asyncio.CancelledError (Light-Heart-Labs#8) - db_postgres.py: Add conn.rollback() on failed SQL to prevent connection pool poisoning (Light-Heart-Labs#10) Installer: - detection.sh: Run systemd auto-resume service as root instead of $USER to prevent sudo password hang and permission errors (Light-Heart-Labs#11)
igorls
referenced
this pull request
in igorls/DreamServer
Mar 10, 2026
… audit CRITICAL: - #1: Command injection via SUDO_USER — switched execSync to execFileSync in getUserHome() to bypass shell interpolation - #2: Symlink attack in /tmp — selfUpdate() now uses mkdtempSync with 0700 perms instead of hardcoded /tmp paths HIGH: - #3: SHA256 verification failure — download binary with artifact name so sha256sum --check finds the correct file - Light-Heart-Labs#4: Broken rollback — verify new binary via exitCode check, not dead catch block (throwOnError: false skips catch) - Light-Heart-Labs#5: Data loss in uninstall — docker compose down -v now conditional on !keepData - Light-Heart-Labs#6: rm -rf path safety — refuse system directories (/, /home, /root, /usr, etc.) with structural depth check MEDIUM: - Light-Heart-Labs#7: Model download failure halts install (throw instead of silent return) — prevents llama-server crash-loop - Light-Heart-Labs#8: Tier change now applies CTX_SIZE even when model name unchanged (Tier 1->2 both use qwen3-8b but differ in context) Tests: updated model.test.ts to expect throw on download failure All 138 tests passing
Lightheartdevs
added a commit
that referenced
this pull request
Mar 30, 2026
#3 Special section: reworded as continuing ally, not past tense. "Drives" not "drove", "keeps bringing" not "brought". Resistance list: restored as #3 contributor (after Yasin and Youness) with full contribution details. He belongs in both places. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Lightheartdevs
added a commit
that referenced
this pull request
Mar 30, 2026
docs: fix Tony's Wall of Heroes — present tense + Resistance #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_yaml()/Parse-Yamlnow scopes key lookups to YAML sections using"section.key"format (e.g.,"token_spy.enabled"instead of"enabled"). Previously, duplicate keys likeenabled,port,hostacrosssession_cleanup/tool_proxy/token_spysections would silently return the wrong value.dangerouslyDisableDeviceAuthandallowInsecureAuth.RepetitionDurationto cleanup task trigger for reliability.Test plan
parse_yamlreturns correct per-section valuesParse-Yamlreturns correct per-section valuessystem_userstill work without section prefix