This repository was archived by the owner on May 6, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
runtimes
in config for GitHub action integration?What does this PR do? [optional]
Add support for nn-template.
Did you have fun?
Always 🙃
Missing
Cookiecutter integration
The nn-template uses cookiecutter to generate a parametrized project from a template.
Thus it is not enough to clone/checkout a repository to obtain a working project.
In our CI we are using the following to: (1) generate the project with cookiecutter and (2) by-pass the interactive setup (with the hacky echo command)
Dependencies
This project uses a combination of conda and pip, most of the dependencies are specified in the
setup.cfg
file.To configure an environment, thus, there are two options (after changing the working directory to the cookiecutter-generated project):
conda
:conda env create -f env.yaml
pip install ".[dev]"
I am not sure which is the best option here, if we want to test the development setup I think the 1. would be more adequate.
Complete config
Part of the file is still borrowed from the template config, e.g. the dependencies, runtimes and
before_test
(p.s. the template file indicated in the README asconfigs/template.yaml
does not exists anymore).These are the main challenges I see at the moment. Once the environment is active to run the tests (and maybe the pre-commits) it is enough to:
Please feel free to contribute to this PR if you have any spare time! Otherwise I will try to understand better how to solve these problems in the Lightning's ecosystem CI (not in the immediate future though!).
@Borda @rasbt @Flegyas