Skip to content

fix: correct none reasoning mapping for small gemini models #65

Merged
k223kim merged 7 commits into
mainfrom
handle-none-gemini
Sep 18, 2025
Merged

fix: correct none reasoning mapping for small gemini models #65
k223kim merged 7 commits into
mainfrom
handle-none-gemini

Conversation

@Danidapena
Copy link
Copy Markdown
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Maps None reasoning effort for small gemini models to "none" string

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Comment thread src/litai/llm.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84%. Comparing base (a370729) to head (ac15643).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #65   +/-   ##
==================================
  Coverage    84%   84%           
==================================
  Files         8     8           
  Lines       466   469    +3     
==================================
+ Hits        390   393    +3     
  Misses       76    76           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@k223kim k223kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k223kim k223kim merged commit bef00d1 into main Sep 18, 2025
31 checks passed
@k223kim k223kim deleted the handle-none-gemini branch September 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants