Fix rope_cache_length computation for models with rope_local_base_freq #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2178
The root cause of the bug:
In
litgpt/generate/sequentially.pyline 65, the code computesrope_cache_lengthas:model.cos.size(-1)For models with
rope_local_base_freq, the RoPE cache has shape(seq_len, n_elem, 2)instead of(seq_len, n_elem).Using
.size(-1)returns 2 instead of the correctn_elem(e.g., 128), causing the KV cache to be initialized with incorrect head dimensions.Solution:
In
litgpt/generate/sequentially.py:Testing:
Above script produces the expected output when the fix is applied.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.