Skip to content

update last release with .post [rebase & merge] #20755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 25, 2025

What does this PR do?

minor patch

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20755.org.readthedocs.build/en/20755/

@github-actions github-actions bot added docs Documentation related ci Continuous Integration release fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/conf.py, .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, docs/source-pytorch/conf.py, .github/workflows/docs-build.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .github/workflows/code-checks.yml, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/version.info.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, src/version.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Borda and others added 6 commits April 25, 2025 20:00
(cherry picked from commit d57c2a3)
* making litmodels message clearer

* linter

---------

Co-authored-by: Jirka B <[email protected]>
(cherry picked from commit 4281b58)
setting logger's codeower

(cherry picked from commit f01ff14)
(cherry picked from commit 1af7f73)
* update model message
* nitpick_ignore

(cherry picked from commit 6cf2581)
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86%. Comparing base (878ecf5) to head (aa83fd3).
Report is 6 commits behind head on release/stable.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/stable   #20755    +/-   ##
================================================
- Coverage              87%      86%    -1%     
================================================
  Files                 268      268            
  Lines               23447    23447            
================================================
- Hits                20497    20251   -246     
- Misses               2950     3196   +246     

@lexierule lexierule merged commit 638ee9e into release/stable Apr 25, 2025
106 checks passed
@lexierule lexierule deleted the releasing/next branch April 25, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants