Skip to content

Added warmup parameter to early stopping cb #20778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Furkan-rgb
Copy link

@Furkan-rgb Furkan-rgb commented Apr 30, 2025

What does this PR do?

This pull request introduces a new feature to the EarlyStopping callback in PyTorch Lightning, allowing users to specify the starting epoch for monitoring early stopping. Additionally, it updates imports to use the pytorch_lightning namespace and improves example documentation. Below is a summary of the most important changes:

New Feature: Starting Epoch for Early Stopping

  • Added a new parameter start_from_epoch to the EarlyStopping callback, allowing users to specify the epoch from which early stopping monitoring begins. Defaults to 0. [1] [2] [3]
  • Updated the _run_early_stopping_check method to skip the early stopping check if the current epoch is less than start_from_epoch.

Namespace Update

  • Updated all imports from lightning.pytorch to pytorch_lightning for consistency with the latest namespace conventions. [1] [2]

Documentation Improvements

  • Enhanced the example in the docstring to demonstrate how to use the new start_from_epoch parameter.

Fixes #<issue_number>

No breaking changes!

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20778.org.readthedocs.build/en/20778/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant