Skip to content

check param is of nn.Parameter type for pruning sanitization #20783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chanokin
Copy link

@chanokin chanokin commented May 3, 2025

Pruning breaks because of non-Parameter types being passed through the pipeline. This came up for an LSTM module, the bias parameter is a boolean which breaks later stages of the pruning.

What does this PR do?

I've only added a further check for the type of "prunable parameters" in the sanitize_parameters_to_prune function. I check if the parameter is of type nn.Parameter so it has the to method and device property.

Fixes #10835

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20783.org.readthedocs.build/en/20783/

This came up for an LSTM module, the bias parameter is a boolean which later stages of the pruning.
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 3, 2025
@chanokin chanokin changed the title check param is of nn.Parameter type check param is of nn.Parameter type for pruning sanitization May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Pruning Callback Failing
1 participant