check param is of nn.Parameter type for pruning sanitization #20783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pruning breaks because of non-
Parameter
types being passed through the pipeline. This came up for an LSTM module, the bias parameter is a boolean which breaks later stages of the pruning.What does this PR do?
I've only added a further check for the type of "prunable parameters" in the
sanitize_parameters_to_prune
function. I check if the parameter is of typenn.Parameter
so it has theto
method anddevice
property.Fixes #10835
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20783.org.readthedocs.build/en/20783/