-
Notifications
You must be signed in to change notification settings - Fork 3.6k
refactor: try catch a more specific exception during log_metrics. #21271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: try catch a more specific exception during log_metrics. #21271
Conversation
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (49%) is below the target coverage (99%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #21271 +/- ##
=========================================
- Coverage 89% 49% -40%
=========================================
Files 269 266 -3
Lines 22050 21994 -56
=========================================
- Hits 19727 10844 -8883
- Misses 2323 11150 +8827 |
What does this PR do?
Handle a more specific exception class during
TensorBoardLogger.log_metrics, and remove its todo.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21271.org.readthedocs.build/en/21271/