Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Oct 6, 2025

What does this PR do?

Handle a more specific exception class during TensorBoardLogger.log_metrics, and remove its todo.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21271.org.readthedocs.build/en/21271/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49%. Comparing base (8f702b3) to head (0ce2830).

❌ Your project check has failed because the head coverage (49%) is below the target coverage (99%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (8f702b3) and HEAD (0ce2830). Click for more details.

HEAD has 434 uploads less than BASE
Flag BASE (8f702b3) HEAD (0ce2830)
cpu 118 24
lightning_fabric 30 12
pytest 60 24
python3.12 36 8
python3.12.7 35 6
python3.10 12 3
lightning 59 12
python3.11 24 6
python 11 1
pytorch2.2.2 6 0
pytest-full 58 0
pytorch2.4.1 5 0
pytorch2.3 6 0
pytorch2.1 11 0
pytorch2.9 6 0
pytorch_lightning 29 0
pytorch2.7 6 0
pytorch2.5.1 6 0
pytorch2.8 6 0
pytorch2.6 6 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21271     +/-   ##
=========================================
- Coverage      89%      49%    -40%     
=========================================
  Files         269      266      -3     
  Lines       22050    21994     -56     
=========================================
- Hits        19727    10844   -8883     
- Misses       2323    11150   +8827     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants