Update pyproject.toml tool.ruff target to py310#21334
Conversation
38b7936 to
e052da7
Compare
for more information, see https://pre-commit.ci
|
@matsumotosan I think #21344 needs to be merged before tests can pass for this PR |
|
@SkafteNicki I agree. I figured I could take a look at the changes the linter would make since it would be a lot. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21334 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 270 270
Lines 23888 23890 +2
=======================================
- Hits 20668 20667 -1
- Misses 3220 3223 +3 |
|
Hi @matsumotosan, just to confirm, if future PRs use |
|
@deependujha Most of the changes were introduced by pre-commit when I changed the python version, so it should be automatically handled. I think that runtime type annotations may not be handled automatically though since I had to manually change a few of those for this PR. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…proved clarity" This reverts commit 896dbf7.
…py310 # Conflicts: # src/lightning/fabric/accelerators/xla.py # src/lightning/fabric/plugins/io/xla.py # src/lightning/fabric/plugins/precision/bitsandbytes.py # src/lightning/fabric/plugins/precision/transformer_engine.py # src/lightning/fabric/strategies/deepspeed.py # src/lightning/fabric/strategies/launchers/xla.py # src/lightning/fabric/strategies/xla.py # src/lightning/fabric/strategies/xla_fsdp.py # src/lightning/pytorch/loggers/comet.py # src/lightning/pytorch/loggers/mlflow.py # src/lightning/pytorch/loggers/neptune.py # src/lightning/pytorch/loggers/wandb.py # src/lightning/pytorch/plugins/precision/deepspeed.py # src/lightning/pytorch/plugins/precision/xla.py # src/lightning/pytorch/strategies/deepspeed.py # src/lightning/pytorch/strategies/single_xla.py # src/lightning/pytorch/strategies/xla.py
What does this PR do?
Update ruff target version to Python 3.10 as part of #21304
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21334.org.readthedocs.build/en/21334/