feat: dcp async checkpoint integration#21515
Open
deependujha wants to merge 48 commits intoLightning-AI:masterfrom
Open
feat: dcp async checkpoint integration#21515deependujha wants to merge 48 commits intoLightning-AI:masterfrom
deependujha wants to merge 48 commits intoLightning-AI:masterfrom
Conversation
Collaborator
Author
|
next pr todos:
self.checkpoint_future_queue: Optional[Future] = queue.Queue(maxsize=2)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21515 +/- ##
========================================
- Coverage 87% 87% -0%
========================================
Files 270 272 +2
Lines 24077 24218 +141
========================================
+ Hits 20868 20976 +108
- Misses 3209 3242 +33 |
tchaton
reviewed
Feb 15, 2026
| def __init__( | ||
| self, | ||
| checkpointer_type: Optional[CHECKPOINTER_TYPE] = None, | ||
| no_dist: bool = True, |
Contributor
There was a problem hiding this comment.
Maybe sharded_checkpoints = False might be more intuitive. But also, this would require to be configured by the strategy.
| "`storage_options` is not supported by AsyncCheckpointIO. Implement a custom CheckpointIO if needed." | ||
| ) | ||
|
|
||
| self._wait() |
Contributor
There was a problem hiding this comment.
Do we need to wait there, can't we have multiple future being created ?
Collaborator
Author
There was a problem hiding this comment.
I didn't do this for the first PR. But added it as todo: #21515 (comment)
should i add this in this pr?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21515.org.readthedocs.build/en/21515/