fix tqdm progress bar using refresh() instead of update()#21539
Open
Mr-Neutr0n wants to merge 2 commits intoLightning-AI:masterfrom
Open
fix tqdm progress bar using refresh() instead of update()#21539Mr-Neutr0n wants to merge 2 commits intoLightning-AI:masterfrom
Mr-Neutr0n wants to merge 2 commits intoLightning-AI:masterfrom
Conversation
The _update_n helper was directly setting bar.n and calling bar.refresh(), which bypasses tqdm's update() logic. This meant EMA-based rate estimation and dynamic miniters were never updated, breaking things like custom smoothing values. Switched to bar.update(value - bar.n) so that tqdm's internal bookkeeping runs properly. Fixes Lightning-AI#21320
Borda
approved these changes
Feb 20, 2026
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_update_nhelper was directly settingbar.nand callingbar.refresh(), which bypasses tqdm'supdate()logic entirely. This means EMA-based rate estimation (_ema_dn,_ema_dt) and dynamicminitersadjustment never run, so things like customsmoothingvalues passed to tqdm don't actually work.The fix swaps the manual
bar.n = value; bar.refresh()forbar.update(value - bar.n), which computes the correct delta and lets tqdm's internal bookkeeping run properly. Sinceupdate()callsrefresh()internally, the visual behavior stays the same.Fixes #21320
📚 Documentation preview 📚: https://pytorch-lightning--21539.org.readthedocs.build/en/21539/