Skip to content

refactor: standardize SIGTERMException instantiation to use explicit parentheses#21665

Open
deependujha wants to merge 2 commits intoLightning-AI:masterfrom
deependujha:standardize-sigterm-exception
Open

refactor: standardize SIGTERMException instantiation to use explicit parentheses#21665
deependujha wants to merge 2 commits intoLightning-AI:masterfrom
deependujha:standardize-sigterm-exception

Conversation

@deependujha
Copy link
Copy Markdown
Collaborator

@deependujha deependujha commented Apr 16, 2026

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21665.org.readthedocs.build/en/21665/

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
3 pipeline(s) require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added the pl Generic label for PyTorch Lightning package label Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (0e20e15) to head (8b24b0b).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (0e20e15) and HEAD (8b24b0b). Click for more details.

HEAD has 546 uploads less than BASE
Flag BASE (0e20e15) HEAD (8b24b0b)
cpu 168 42
python 12 3
lightning_fabric 54 0
pytest 84 0
python3.12.7 36 9
python3.12 48 12
lightning 60 15
python3.11 24 6
python3.10 12 3
python3.13 36 9
pytorch2.1 12 6
pytest-full 84 42
pytorch_lightning 54 27
pytorch2.7 6 3
pytorch2.5.1 6 3
pytorch2.9 12 6
pytorch2.8 12 6
pytorch2.10 12 6
pytorch2.4.1 6 3
pytorch2.3 6 3
pytorch2.6 6 3
pytorch2.2.2 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21665     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       23973    23914     -59     
=========================================
- Hits        20748    18804   -1944     
- Misses       3225     5110   +1885     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant