fix (ci): upgrade probot version in CI#21670
Merged
deependujha merged 8 commits intoLightning-AI:masterfrom Apr 28, 2026
Merged
fix (ci): upgrade probot version in CI#21670deependujha merged 8 commits intoLightning-AI:masterfrom
probot version in CI#21670deependujha merged 8 commits intoLightning-AI:masterfrom
Conversation
probot comment posting on fork PRs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Probot workflow trigger so Probot can post comments on pull requests opened from forks by running in the base repository context.
Changes:
- Switch the workflow trigger from
pull_requesttopull_request_target. - Add an inline note explaining why the trigger change is considered safe for this workflow.
Comments suppressed due to low confidence (1)
.github/workflows/probot-check-group.yml:9
- With
pull_request_target,github.refis the base branch ref andgithub.head_refis only the source branch name (not fork-qualified), so the current concurrency group can collide across different fork PRs that use the same branch name, causing unrelated runs to cancel each other. Consider using a unique key like the PR number (github.event.pull_request.number) in the concurrency group.
pull_request_target:
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 tasks
bhimrazy
approved these changes
Apr 20, 2026
robTheBuildr
approved these changes
Apr 20, 2026
deependujha
commented
Apr 21, 2026
justusschock
approved these changes
Apr 28, 2026
Collaborator
Author
|
update: upgrading to |
probot comment posting on fork PRsprobot version in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Problem
Probot fails to post comments on PRs opened from forks (example failing run). This is because the
pull_requesttrigger runs with a read-only token for fork PRs, which doesn't have permission to write comments.PRs from branches within the same repo are unaffected (example working comment).
Fix
Switch to
pull_request_target, which runs in the context of the base repo and gets a read-write token.Probot only polls check statuses and posts comments; it never checks out PR code, so this is safe to do.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21670.org.readthedocs.build/en/21670/