Skip to content

chore(pre-commit) : update docformatter #21682

Draft
bhimrazy wants to merge 2 commits into
Lightning-AI:masterfrom
bhimrazy:fix/docformatter
Draft

chore(pre-commit) : update docformatter #21682
bhimrazy wants to merge 2 commits into
Lightning-AI:masterfrom
bhimrazy:fix/docformatter

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy commented Apr 21, 2026

What does this PR do?

This PR removes the Python pin for docformatter, which was added in #21587, as a new version 1.7.8 has been released with the required fixes.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@pre-commit-ci pre-commit-ci Bot requested a review from williamFalcon as a code owner April 21, 2026 06:29
@github-actions github-actions Bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86%. Comparing base (efb7328) to head (ca91552).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21682    +/-   ##
========================================
- Coverage      87%      86%    -1%     
========================================
  Files         270      270            
  Lines       23973    23974     +1     
========================================
- Hits        20751    20553   -198     
- Misses       3222     3421   +199     

@bhimrazy bhimrazy marked this pull request as draft April 21, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant