Skip to content

jsonargparse 4.39 required for CLI, check at run-time#21747

Open
adamjstewart wants to merge 2 commits into
Lightning-AI:masterfrom
adamjstewart:deps/jsonargparse
Open

jsonargparse 4.39 required for CLI, check at run-time#21747
adamjstewart wants to merge 2 commits into
Lightning-AI:masterfrom
adamjstewart:deps/jsonargparse

Conversation

@adamjstewart
Copy link
Copy Markdown
Contributor

What does this PR do?

jsonargparse 4.39 has been required by LightningCLI since #20777, and jsonnet has been required since #20899, both in lightning 2.5.2. However, we forgot to update other run-time checks for this, resulting in users not being warned about incompatible jsonargparse installations.

Fixes torchgeo/torchgeo#3741 (comment)

@Borda @robmarkcole

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (932b7e3) to head (8d97792).
✅ All tests successful. No failed tests found.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (932b7e3) and HEAD (8d97792). Click for more details.

HEAD has 538 uploads less than BASE
Flag BASE (932b7e3) HEAD (8d97792)
cpu 166 42
python 12 3
lightning_fabric 54 0
pytest 82 0
python3.12 48 12
python3.13 36 9
lightning 58 15
python3.11 23 6
python3.12.7 35 9
python3.10 12 3
pytorch2.5.1 6 3
pytest-full 84 42
pytorch2.8 12 6
pytorch_lightning 54 27
pytorch2.9 12 6
pytorch2.10 12 6
pytorch2.1 12 6
pytorch2.2.2 6 3
pytorch2.3 6 3
pytorch2.7 6 3
pytorch2.6 6 3
pytorch2.4.1 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21747     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       23973    23914     -59     
=========================================
- Hits        20748    18803   -1945     
- Misses       3225     5111   +1886     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lightning CLI: missing 1 required keyword-only argument: applied_instantiation_links

2 participants