jsonargparse 4.39 required for CLI, check at run-time#21747
Open
adamjstewart wants to merge 2 commits into
Open
jsonargparse 4.39 required for CLI, check at run-time#21747adamjstewart wants to merge 2 commits into
adamjstewart wants to merge 2 commits into
Conversation
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
for more information, see https://pre-commit.ci
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21747 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 23973 23914 -59
=========================================
- Hits 20748 18803 -1945
- Misses 3225 5111 +1886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
jsonargparse 4.39 has been required by LightningCLI since #20777, and jsonnet has been required since #20899, both in lightning 2.5.2. However, we forgot to update other run-time checks for this, resulting in users not being warned about incompatible jsonargparse installations.
Fixes torchgeo/torchgeo#3741 (comment)
@Borda @robmarkcole
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist