Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Revision components related model.gans.pix2pix#883

Draft
Jungwon-Lee wants to merge 54 commits into
Lightning-Universe:masterfrom
Jungwon-Lee:revision_pix2pix
Draft

Revision components related model.gans.pix2pix#883
Jungwon-Lee wants to merge 54 commits into
Lightning-Universe:masterfrom
Jungwon-Lee:revision_pix2pix

Conversation

@Jungwon-Lee

@Jungwon-Lee Jungwon-Lee commented Sep 18, 2022

Copy link
Copy Markdown

What does this PR do?

Part of #839

pl_bolts.models.gans.pix2pix.components.DownSampleConv
pl_bolts.models.gans.pix2pix.components.Generator
pl_bolts.models.gans.pix2pix.components.PatchGAN
pl_bolts.models.gans.pix2pix.components.UpSampleConv
pl_bolts.models.gans.pix2pix.pix2pix_module._weights_init
pl_bolts.models.gans.pix2pix.pix2pix_module.Pix2Pix

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions Bot added the model label Sep 18, 2022
@Jungwon-Lee Jungwon-Lee force-pushed the revision_pix2pix branch 3 times, most recently from e11ca2d to c2d9426 Compare September 18, 2022 04:26
@Jungwon-Lee Jungwon-Lee marked this pull request as ready for review September 18, 2022 05:05
@mergify mergify Bot removed the has conflicts label May 20, 2023
@Borda Borda enabled auto-merge (squash) May 20, 2023 20:50
@mergify mergify Bot removed the has conflicts label May 31, 2023
@Borda Borda marked this pull request as draft June 16, 2023 18:18
auto-merge was automatically disabled June 16, 2023 18:18

Pull request was converted to draft

@Borda

Borda commented Jun 29, 2023

Copy link
Copy Markdown
Member

@Jungwon-Lee how is it going here? 🐰

@otaj otaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be seeing this in my list of reviews anymore, so, I'm approving :D

How are you guys doing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants